From: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
To: Andy Duan <fugang.duan@nxp.com>,
"David S. Miller" <davem@davemloft.net>,
Troy Kisky <troy.kisky@boundarydevices.com>,
Andrew Lunn <andrew@lunn.ch>, Eric Nelson <eric@nelint.com>,
Philippe Reynes <tremyfr@gmail.com>,
Johannes Berg <johannes@sipsolutions.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: Chris Healy <cphealy@gmail.com>,
Fabio Estevam <fabio.estevam@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [patch net] net: fec: cache statistics while device is down
Date: Tue, 29 Nov 2016 08:43:17 +0300 [thread overview]
Message-ID: <bd33a3da-ae19-151a-6616-dde242f25320@cogentembedded.com> (raw)
In-Reply-To: <AM4PR0401MB2260081367AC9A140448A631FF8D0@AM4PR0401MB2260.eurprd04.prod.outlook.com>
> >
> >+ fec_enet_update_ethtool_stats(ndev);
> >+
> If user never open the interface, ethtool_stats[] always is 0 that are not expected.
> So, it also should be called at . fec_enet_init() ?
I don't think that zero stats is wrong for never-opened interface.
However a call at init path won't hurt, so I'll add it, just to clear
the question.
Nikita
prev parent reply other threads:[~2016-11-29 5:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-28 14:27 [patch net] net: fec: cache statistics while device is down Nikita Yushchenko
2016-11-29 1:22 ` Andy Duan
2016-11-29 5:43 ` Nikita Yushchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd33a3da-ae19-151a-6616-dde242f25320@cogentembedded.com \
--to=nikita.yoush@cogentembedded.com \
--cc=andrew@lunn.ch \
--cc=cphealy@gmail.com \
--cc=davem@davemloft.net \
--cc=eric@nelint.com \
--cc=fabio.estevam@nxp.com \
--cc=fugang.duan@nxp.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tremyfr@gmail.com \
--cc=troy.kisky@boundarydevices.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox