From: Eric Dumazet <eric.dumazet@gmail.com>
To: Maninder Singh <maninder1.s@samsung.com>,
davem@davemloft.net, shuahkh@osg.samsung.com
Cc: netdev@vger.kernel.org, linux-api@vger.kernel.org,
linux-kernel@vger.kernel.org, edumazet@google.com,
pankaj.m@samsung.com, a.sahrawat@samsung.com,
Vaneet Narang <v.narang@samsung.com>
Subject: Re: [PATCH 1/1] selftest/net: fix protocol family to work for IPv4.
Date: Thu, 2 Aug 2018 06:03:13 -0700 [thread overview]
Message-ID: <bd39eee1-ff9f-db4e-2948-2cb9a7a651f7@gmail.com> (raw)
In-Reply-To: <20180802100201epcas5p390bb362ccabaa99087eff88af37bffb2~HCQZjTEZd0101301013epcas5p3C@epcas5p3.samsung.com>
On 08/02/2018 02:57 AM, Maninder Singh wrote:
> use actual protocol family passed by user rather than hardcoded
> AF_INTE6 to cerate sockets.
> current code is not working for IPv4.
>
> Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
> Signed-off-by: Vaneet Narang <v.narang@samsung.com>
> ---
> tools/testing/selftests/net/tcp_mmap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/net/tcp_mmap.c b/tools/testing/selftests/net/tcp_mmap.c
> index 77f7627..e8c5dff 100644
> --- a/tools/testing/selftests/net/tcp_mmap.c
> +++ b/tools/testing/selftests/net/tcp_mmap.c
> @@ -402,7 +402,7 @@ int main(int argc, char *argv[])
> exit(1);
> }
>
> - fd = socket(AF_INET6, SOCK_STREAM, 0);
> + fd = socket(cfg_family, SOCK_STREAM, 0);
> if (fd == -1) {
> perror("socket");
> exit(1);
>
Darn, someone spotted my hidden attempt to kill IPv4 ;)
Reviewed-by: Eric Dumazet <edumazet@google.com>
next prev parent reply other threads:[~2018-08-02 13:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180802100201epcas5p390bb362ccabaa99087eff88af37bffb2@epcas5p3.samsung.com>
2018-08-02 9:57 ` [PATCH 1/1] selftest/net: fix protocol family to work for IPv4 Maninder Singh
2018-08-02 13:03 ` Eric Dumazet [this message]
2018-08-02 17:30 ` David Miller
2018-08-02 17:35 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd39eee1-ff9f-db4e-2948-2cb9a7a651f7@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=a.sahrawat@samsung.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maninder1.s@samsung.com \
--cc=netdev@vger.kernel.org \
--cc=pankaj.m@samsung.com \
--cc=shuahkh@osg.samsung.com \
--cc=v.narang@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).