* [PATCH 1/1] selftest/net: fix protocol family to work for IPv4. [not found] <CGME20180802100201epcas5p390bb362ccabaa99087eff88af37bffb2@epcas5p3.samsung.com> @ 2018-08-02 9:57 ` Maninder Singh 2018-08-02 13:03 ` Eric Dumazet ` (2 more replies) 0 siblings, 3 replies; 4+ messages in thread From: Maninder Singh @ 2018-08-02 9:57 UTC (permalink / raw) To: davem, shuahkh Cc: netdev, linux-api, linux-kernel, edumazet, pankaj.m, a.sahrawat, Maninder Singh, Vaneet Narang use actual protocol family passed by user rather than hardcoded AF_INTE6 to cerate sockets. current code is not working for IPv4. Signed-off-by: Maninder Singh <maninder1.s@samsung.com> Signed-off-by: Vaneet Narang <v.narang@samsung.com> --- tools/testing/selftests/net/tcp_mmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/net/tcp_mmap.c b/tools/testing/selftests/net/tcp_mmap.c index 77f7627..e8c5dff 100644 --- a/tools/testing/selftests/net/tcp_mmap.c +++ b/tools/testing/selftests/net/tcp_mmap.c @@ -402,7 +402,7 @@ int main(int argc, char *argv[]) exit(1); } - fd = socket(AF_INET6, SOCK_STREAM, 0); + fd = socket(cfg_family, SOCK_STREAM, 0); if (fd == -1) { perror("socket"); exit(1); -- 1.9.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] selftest/net: fix protocol family to work for IPv4. 2018-08-02 9:57 ` [PATCH 1/1] selftest/net: fix protocol family to work for IPv4 Maninder Singh @ 2018-08-02 13:03 ` Eric Dumazet 2018-08-02 17:30 ` David Miller 2018-08-02 17:35 ` David Miller 2 siblings, 0 replies; 4+ messages in thread From: Eric Dumazet @ 2018-08-02 13:03 UTC (permalink / raw) To: Maninder Singh, davem, shuahkh Cc: netdev, linux-api, linux-kernel, edumazet, pankaj.m, a.sahrawat, Vaneet Narang On 08/02/2018 02:57 AM, Maninder Singh wrote: > use actual protocol family passed by user rather than hardcoded > AF_INTE6 to cerate sockets. > current code is not working for IPv4. > > Signed-off-by: Maninder Singh <maninder1.s@samsung.com> > Signed-off-by: Vaneet Narang <v.narang@samsung.com> > --- > tools/testing/selftests/net/tcp_mmap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/net/tcp_mmap.c b/tools/testing/selftests/net/tcp_mmap.c > index 77f7627..e8c5dff 100644 > --- a/tools/testing/selftests/net/tcp_mmap.c > +++ b/tools/testing/selftests/net/tcp_mmap.c > @@ -402,7 +402,7 @@ int main(int argc, char *argv[]) > exit(1); > } > > - fd = socket(AF_INET6, SOCK_STREAM, 0); > + fd = socket(cfg_family, SOCK_STREAM, 0); > if (fd == -1) { > perror("socket"); > exit(1); > Darn, someone spotted my hidden attempt to kill IPv4 ;) Reviewed-by: Eric Dumazet <edumazet@google.com> ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] selftest/net: fix protocol family to work for IPv4. 2018-08-02 9:57 ` [PATCH 1/1] selftest/net: fix protocol family to work for IPv4 Maninder Singh 2018-08-02 13:03 ` Eric Dumazet @ 2018-08-02 17:30 ` David Miller 2018-08-02 17:35 ` David Miller 2 siblings, 0 replies; 4+ messages in thread From: David Miller @ 2018-08-02 17:30 UTC (permalink / raw) To: maninder1.s Cc: shuahkh, netdev, linux-api, linux-kernel, edumazet, pankaj.m, a.sahrawat, v.narang From: Maninder Singh <maninder1.s@samsung.com> Date: Thu, 2 Aug 2018 15:27:27 +0530 > use actual protocol family passed by user rather than hardcoded > AF_INTE6 to cerate sockets. > current code is not working for IPv4. > > Signed-off-by: Maninder Singh <maninder1.s@samsung.com> > Signed-off-by: Vaneet Narang <v.narang@samsung.com> Applied. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] selftest/net: fix protocol family to work for IPv4. 2018-08-02 9:57 ` [PATCH 1/1] selftest/net: fix protocol family to work for IPv4 Maninder Singh 2018-08-02 13:03 ` Eric Dumazet 2018-08-02 17:30 ` David Miller @ 2018-08-02 17:35 ` David Miller 2 siblings, 0 replies; 4+ messages in thread From: David Miller @ 2018-08-02 17:35 UTC (permalink / raw) To: maninder1.s Cc: shuahkh, netdev, linux-api, linux-kernel, edumazet, pankaj.m, a.sahrawat, v.narang From: Maninder Singh <maninder1.s@samsung.com> Date: Thu, 2 Aug 2018 15:27:27 +0530 > use actual protocol family passed by user rather than hardcoded > AF_INTE6 to cerate sockets. > current code is not working for IPv4. > > Signed-off-by: Maninder Singh <maninder1.s@samsung.com> > Signed-off-by: Vaneet Narang <v.narang@samsung.com> Applied. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-08-02 17:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20180802100201epcas5p390bb362ccabaa99087eff88af37bffb2@epcas5p3.samsung.com>
2018-08-02 9:57 ` [PATCH 1/1] selftest/net: fix protocol family to work for IPv4 Maninder Singh
2018-08-02 13:03 ` Eric Dumazet
2018-08-02 17:30 ` David Miller
2018-08-02 17:35 ` David Miller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).