Netdev List
 help / color / mirror / Atom feed
From: Chuan Liu <chuan.liu@amlogic.com>
To: tanure@linux.com
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
	xianwei.zhao@amlogic.com, Andrew Lunn <andrew+netdev@lunn.ch>,
	davem@davemloft.net, Eric Dumazet <edumazet@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Kevin Hilman <khilman@baylibre.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	Maxime Chevallier <maxime.chevallier@bootlin.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
	Qingpeng.Yang@amlogic.com
Subject: Re: [PATCH v5 2/7] dt-bindings: net: amlogic,meson-dwmac: add amlogic,t7-dwmac
Date: Mon, 16 Nov 2026 20:03:07 +0800	[thread overview]
Message-ID: <bd4c8a15-ab13-459f-8fb5-fe3f3b04af43@amlogic.com> (raw)
In-Reply-To: <CAJX_Q+0seFwDvd6zksLnJjWYJJY1QcLc1gAjr=FN1p+aTdumpw@mail.gmail.com>

Hi Lucas,

On 11/13/2026 7:40 PM, Lucas Tanure wrote:
> [ EXTERNAL EMAIL ]
> 
> On Tue, Nov 10, 2026 at 11:43 AM Chuan Liu <chuan.liu@amlogic.com> wrote:
>>
>> Hi Lucas,
>>
>> On 11/9/2026 11:43 PM, Lucas Tanure wrote:
>>> [ EXTERNAL EMAIL ]
>>>
>>> On Fri, Nov 6, 2026 at 3:16 AM Chuan Liu <chuan.liu@amlogic.com> wrote:
>>>>
>>>> Hi Krzysztof, Lucas,
>>>>
>>>> On 11/5/2026 7:57 PM, Krzysztof Kozlowski wrote:
>>>>> [ EXTERNAL EMAIL ]
>>>>>
>>>>> On Tue, Nov 03, 2026 at 04:37:10PM +0000, Lucas Tanure wrote:
>>>>>>
>>>>>> Assisted-by: LLM
>>>>>
>>>>> Drop this one.
>>>>>
>>>>>> Signed-off-by: Lucas Tanure <tanure@linux.com>
>>>>>> ---
>>>>>>     .../bindings/net/amlogic,meson-dwmac.yaml     | 59 +++++++++++++++++++
>>>>>>     1 file changed, 59 insertions(+)
>>>>>>
>>>>>> diff --git a/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml b/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml
>>>>>> index e769c9bb70d8..6de013e3e8f6 100644
>>>>>> --- a/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml
>>>>>> +++ b/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml
>>>>>> @@ -23,6 +23,7 @@ select:
>>>>>>               - amlogic,meson-gxbb-dwmac
>>>>>>               - amlogic,meson-axg-dwmac
>>>>>>               - amlogic,meson-g12a-dwmac
>>>>>> +          - amlogic,t7-dwmac
>>>>>>       required:
>>>>>>         - compatible
>>>>>>
>>>>>> @@ -57,6 +58,59 @@ allOf:
>>>>>>                 - const: clkin1
>>>>>>                 - const: timing-adjustment
>>>>>>
>>>>>> +  - if:
>>>>>> +      properties:
>>>>>> +        compatible:
>>>>>> +          contains:
>>>>>> +            const: amlogic,t7-dwmac
>>>>>> +    then:
>>>>>> +      properties:
>>>>>> +        clocks:
>>>>>> +          items:
>>>>>> +            - description: GMAC main clock
>>>>>> +            - description: First parent clock of the internal mux
>>>>>> +            - description: Second parent clock of the internal mux
>>>>>> +            - description:
>>>>>> +                clock of the pipeline stage inserted in the bus path between
>>>>>> +                the controller and the DRAM. Without it, the controller cannot
>>>>>> +                complete DMA transfers.
>>>>>> +            - description:
>>>>>> +                clock of the register block holding PRG_ETH0 and PRG_ETH1.
>>>>>> +                Without it, the block reads as zero and ignores writes.
>>>>>
>>>>> This sounds like you take clock from other block. That's wrong, that
>>>>> device should take its own clock.
>>>>
>>>> I see that the clock in the dts patch corresponds to <&clkc_periphs
>>>> CLKID_SYS_ETHPHY>. This clock provides the working clock for the APB Bus
>>>> of the ETH PHY controller, and this clock will affect the register
>>>> reading and writing of the ETH PHY (including the ETH_PLL). See section
>>>> 15.3.4.2 RegisterDescription in A311D2 Datasheet for details.
>>>
>>> Thanks. That section is the PHY block at 0xfe028000, the region of the
>>> mdio multiplexer node. The registers in this description are PRG_ETH0
>>> and PRG_ETH1 in eth_top at 0xfe024000. On the VIM4 the same gate feeds
>>> them too: with it off they read as zero and ignore writes. My datasheet
>>> revisions do not say which clock feeds eth_top. Can you confirm it is
>>> this one?
>>
>> The information I can confirm is:
>>     - The base address of eth_phy is 0xfe028000, and its corresponding
>> APB clock is <&clkc_periphs CLKID_SYS_ETHPHY>.
>>     - The base address of eth_top is 0xfe024000, and the base address of
>> eth_mac is 0xfdc00000; their corresponding APB clock is <&clkc_periphs
>> CLKID_SYS_ETH>.
> 
> That is not what the VIM4 does. The stmmac core enables
> CLKID_SYS_ETH before any glue code runs. With that clock on and
> CLKID_SYS_ETHPHY off, PRG_ETH0 and PRG_ETH1 read as zero and the
> driver's writes are lost: U-Boot's 0xa0000 was still in PRG_ETH1
> after the driver had written 0. Enabling CLKID_SYS_ETHPHY right
> before the write makes it land. That was the v3 bug, every frame a
> CRC error. I repeated it today on the running kernel, toggling only
> bit 4 of CLKCTRL_SYS_CLK_EN0_REG0 from user space, every other gate
> left on:
> 
>    both gates on        EN0=ffffffff EN1=ffffffff PRG_ETH0=00001601
>    ethphy off, eth on   EN0=ffffffef EN1=ffffffff PRG_ETH0=00000000
>    ethphy restored      EN0=ffffffff EN1=ffffffff PRG_ETH0=00001601
> 

Sorry that the information I gave before is not completely accurate. The 
conclusion you drew from the test is correct. The relationship between 
them should be:
     - eth_mac:  works with CLKID_SYS_ETH only
     - eth_phy:  works with CLKID_SYS_ETHPHY only
     - eth_top:  needs both CLKID_SYS_ETH and CLKID_SYS_ETHPHY

> So on this chip CLKID_SYS_ETH alone does not give access to eth_top.
> Could the register interface of eth_top sit behind the eth_phy APB
> slave?

eth_top is the glue between the eth_mac and eth_phy domains, its 
registers are consumed on both sides of that boundary, so a register 
access has to complete in both clock domains - with either gate off, 
reads return zero and writes are lost.

> Either way the MAC node has to enable CLKID_SYS_ETHPHY, and
> the binding will describe it as the clock of the glue registers.
> 
>>
>> The CPU reads and writes the registers of these peripheral controllers
>> (or Processing Units) via the APB. Consequently, the registers of these
>> controllers cannot be read and written properly if the corresponding APB
>> clock (sys_clk/clk81) is not enabled.
>>
>>>
>>> Thanks,
>>> Lucas
>>>
>>>>
>>>>>
>>>>>
>>>>>> +
>>>>>> +        clock-names:
>>>>>> +          items:
>>>>>> +            - const: stmmaceth
>>>>>> +            - const: clkin0
>>>>>> +            - const: clkin1
>>>>>> +            - const: pipeline
>>>>>> +            - const: pclk
>>>>>> +
>>>>>> +        # The PHY adds the 2ns RGMII delays, see ethernet-controller.yaml.
>>>>>> +        # The RX delay line of this glue is fine tuning in 200ps steps,
>>>>>> +        # added on top of what phy-mode describes. The TX side has no fine
>>>>>> +        # tuning: its only step is a quarter of the clock period, the full
>>>>>> +        # 2ns at 1Gbit/s, so the TX property is not accepted.
>>>>>> +        tx-internal-delay-ps: false
>>>>>> +
>>>>>> +        # Deprecated: new SoCs use the standard *-internal-delay-ps
>>>>>> +        # properties instead.
>>>>>> +        amlogic,tx-delay-ns: false
>>>>>> +        amlogic,rx-delay-ns: false
>>>>>> +
>>>>>> +  # Delay definitions for Meson8b and newer
>>>>>> +  - if:
>>>>>> +      properties:
>>>>>> +        compatible:
>>>>>> +          contains:
>>>>>> +            enum:
>>>>>> +              - amlogic,meson8b-dwmac
>>>>>> +              - amlogic,meson8m2-dwmac
>>>>>> +              - amlogic,meson-gxbb-dwmac
>>>>>> +              - amlogic,meson-axg-dwmac
>>>>>> +              - amlogic,meson-g12a-dwmac
>>>>>> +    then:
>>>>>> +      properties:
>>>>>>             amlogic,tx-delay-ns:
>>>>>>               enum: [0, 2, 4, 6]
>>>>>>               default: 2
>>>>>> @@ -106,6 +160,7 @@ allOf:
>>>>>>               contains:
>>>>>>                 enum:
>>>>>>                   - amlogic,meson-g12a-dwmac
>>>>>> +              - amlogic,t7-dwmac
>>>>>>         then:
>>>>>>           properties:
>>>>>>             rx-internal-delay-ps:
>>>>>> @@ -142,6 +197,10 @@ properties:
>>>>>>           - items:
>>>>>>               - const: amlogic,meson6-dwmac
>>>>>>               - const: snps,dwmac
>>>>>> +      - items:
>>>>>> +          - const: amlogic,t7-dwmac
>>>>>> +          - const: snps,dwmac-5.10a
>>>>>> +          - const: snps,dwmac
>>>>>
>>>>> I see no such hunk in the code, so not sure how to review this.
>>>>>
>>>>> Best regards,
>>>>> Krzysztof
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> linux-amlogic mailing list
>>>>> linux-amlogic@lists.infradead.org
>>>>> http://lists.infradead.org/mailman/listinfo/linux-amlogic
>>>>
>>>> --
>>>> Best regards,
>>>> Chuan
>>>>
>>
>> --
>> Best regards,
>> Chuan
>>
> Thanks,
> Lucas

-- 
Best regards,
Chuan


  reply	other threads:[~2026-11-16 12:03 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-03 16:37 [PATCH v5 0/7] Add ethernet support for the Amlogic T7 Lucas Tanure
2026-11-03 16:37 ` [PATCH v5 1/7] dt-bindings: net: amlogic,meson-dwmac: list the compatible combinations Lucas Tanure
2026-11-03 16:37 ` [PATCH v5 2/7] dt-bindings: net: amlogic,meson-dwmac: add amlogic,t7-dwmac Lucas Tanure
2026-11-05 11:57   ` Krzysztof Kozlowski
2026-11-05 11:58     ` Krzysztof Kozlowski
2026-11-06  3:16     ` Chuan Liu
2026-11-09 15:43       ` Lucas Tanure
2026-11-10 11:42         ` Chuan Liu
2026-11-13 11:40           ` Lucas Tanure
2026-11-16 12:03             ` Chuan Liu [this message]
2026-11-09 15:42     ` Lucas Tanure
2026-11-03 16:37 ` [PATCH v5 3/7] net: stmmac: dwmac-meson8b: add support for the Amlogic T7 Lucas Tanure
2026-11-03 16:37 ` [PATCH v5 4/7] net: stmmac: dwmac-meson8b: follow the generic RGMII delay rules on the T7 Lucas Tanure
2026-11-05 15:47   ` Andrew Lunn
2026-11-03 16:37 ` [PATCH v5 5/7] arm64: dts: amlogic: t7: add the ethernet pinctrl nodes Lucas Tanure
2026-11-03 16:37 ` [PATCH v5 6/7] arm64: dts: amlogic: t7: add the ethernet controller Lucas Tanure
2026-11-03 16:37 ` [PATCH v5 7/7] arm64: dts: amlogic: t7: khadas-vim4: enable the ethernet port Lucas Tanure

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bd4c8a15-ab13-459f-8fb5-fe3f3b04af43@amlogic.com \
    --to=chuan.liu@amlogic.com \
    --cc=Qingpeng.Yang@amlogic.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@kernel.org \
    --cc=jbrunet@baylibre.com \
    --cc=khilman@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=maxime.chevallier@bootlin.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=neil.armstrong@linaro.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=robh@kernel.org \
    --cc=tanure@linux.com \
    --cc=xianwei.zhao@amlogic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox