From: Anton Ivanov <anton.ivanov@cambridgegreys.com>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: Network Development <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>
Subject: Re: BUG:af_packet fails to TX TSO frames
Date: Wed, 11 Oct 2017 17:32:21 +0100 [thread overview]
Message-ID: <bd4f863d-e39a-c31f-712f-1720af8e0024@cambridgegreys.com> (raw)
In-Reply-To: <CAF=yD-+JaS8JwEC2TyUG=Ebaho-MM+gjumrbHYM-H0EK1Hu62Q@mail.gmail.com>
Working through it at the moment.
The validation logic is prohibiting what the hardware considers to be a
perfectly legit skb.
Once I narrow down the culprit I will come back with my findings.
Thanks for pointing me where to look by the way.
A.
On 10/11/17 17:26, Willem de Bruijn wrote:
> On Wed, Oct 11, 2017 at 11:54 AM, Anton Ivanov
> <anton.ivanov@cambridgegreys.com> wrote:
>> It is that patch.
>>
>> I rolled it back and immediately got it to work correctly on a Broadcom
>> Tigon. I can test on all other scenarios, I have tried, I suspect it will
>> come back alive on all of them.
>>
>> I am going to try to trace it through and see exactly where it drops a skb
>> which the card has no issues in accepting.
> It might be in the initialization of gso_type and csum. The virtio_net_hdr
> can encode various combinations of flags that are not allowed by the
> validation logic.
>
--
Anton R. Ivanov
Cambridge Greys Limited, England and Wales company No 10273661
http://www.cambridgegreys.com/
next prev parent reply other threads:[~2017-10-11 16:32 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-11 8:39 BUG:af_packet fails to TX TSO frames Anton Ivanov
2017-10-11 13:39 ` Willem de Bruijn
2017-10-11 13:50 ` Anton Ivanov
2017-10-11 15:54 ` Anton Ivanov
2017-10-11 16:26 ` Willem de Bruijn
2017-10-11 16:32 ` Anton Ivanov [this message]
2017-10-11 18:39 ` Anton Ivanov
2017-10-11 18:57 ` Willem de Bruijn
2017-10-11 19:39 ` Anton Ivanov
2017-10-11 21:05 ` Willem de Bruijn
2017-10-11 21:55 ` Anton Ivanov
2017-10-11 22:01 ` Anton Ivanov
2017-10-12 0:19 ` Willem de Bruijn
2017-10-12 6:11 ` Anton Ivanov
2017-10-12 8:46 ` Anton Ivanov
2017-10-12 13:39 ` Willem de Bruijn
2017-10-12 14:12 ` Anton Ivanov
2017-10-12 15:44 ` Anton Ivanov
2017-10-12 15:57 ` Anton Ivanov
2017-10-12 16:30 ` Willem de Bruijn
2017-10-12 17:25 ` Willem de Bruijn
2017-10-12 17:58 ` Anton Ivanov
2017-10-12 18:41 ` Willem de Bruijn
2017-10-12 19:55 ` Anton Ivanov
2017-10-13 7:25 ` Not BUG, feature :) af_packet " Anton Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd4f863d-e39a-c31f-712f-1720af8e0024@cambridgegreys.com \
--to=anton.ivanov@cambridgegreys.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox