Re: [PATCH 02/11] nvmet-tcp: implement accept mptcp proto

[Nilay Shroff <nilay@linux.ibm.com>]

On 5/28/26 8:40 AM, Geliang Tang wrote:
> From: Geliang Tang<tanggeliang@kylinos.cn>
> 
> An MPTCP-specific version of struct nvmet_tcp_proto is implemented for
> accept sockets. It is assigned to queue->proto when the accepted socket
> protocol is IPPROTO_MPTCP.
> 
> Dedicated MPTCP helpers are introduced for setting accept socket options.
> These helpers (no_linger, set_priority, set_tos) set the values on all
> existing subflows using mptcp_for_each_subflow(). The values are then
> synchronized to other newly created subflows in sync_socket_options().
> 
> Cc: Hannes Reinecke<hare@suse.de>
> Cc: John Meneghini<jmeneghi@redhat.com>
> Cc: Randy Jennings<randyj@purestorage.com>
> Cc: Nilay Shroff<nilay@linux.ibm.com>
> Co-developed-by: zhenwei pi<zhenwei.pi@linux.dev>
> Signed-off-by: zhenwei pi<zhenwei.pi@linux.dev>
> Co-developed-by: Hui Zhu<zhuhui@kylinos.cn>
> Signed-off-by: Hui Zhu<zhuhui@kylinos.cn>
> Co-developed-by: Gang Yan<yangang@kylinos.cn>
> Signed-off-by: Gang Yan<yangang@kylinos.cn>
> Signed-off-by: Geliang Tang<tanggeliang@kylinos.cn>
> ---
>   drivers/nvme/target/tcp.c | 16 ++++++++
>   include/net/mptcp.h       | 12 ++++++
>   net/mptcp/sockopt.c       | 79 +++++++++++++++++++++++++++++++++++++++
>   3 files changed, 107 insertions(+)

I'd recommend splitting this into two patches: the first patch shall
define and export mptcp_sock_xxx() APIs and then the another patch
specific to nvmet which uses those exported methods.

Thanks,
--Nilay