From: Jesper Dangaard Brouer <hawk@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org,
amritha.nambiar@intel.com, aleksander.lobakin@intel.com,
mst@redhat.com, jasowang@redhat.com, xuanzhuo@linux.alibaba.com,
ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
martin.lau@linux.dev, song@kernel.org, yonghong.song@linux.dev,
john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com,
haoluo@google.com, jolsa@kernel.org, bjorn@kernel.org,
magnus.karlsson@intel.com, maciej.fijalkowski@intel.com,
jonathan.lemon@gmail.com, gregkh@linuxfoundation.org,
wangyufen@huawei.com, virtualization@lists.linux-foundation.org
Subject: Re: [PATCH bpf-next v2 2/3] net: move struct netdev_rx_queue out of netdevice.h
Date: Thu, 3 Aug 2023 16:24:26 +0200 [thread overview]
Message-ID: <bd6c0dee-3f2c-3613-a5ff-42cc11268e49@kernel.org> (raw)
In-Reply-To: <20230803010230.1755386-3-kuba@kernel.org>
On 03/08/2023 03.02, Jakub Kicinski wrote:
> struct netdev_rx_queue is touched in only a few places
> and having it defined in netdevice.h brings in the dependency
> on xdp.h, because struct xdp_rxq_info gets embedded in
> struct netdev_rx_queue.
>
> In prep for removal of xdp.h from netdevice.h move all
> the netdev_rx_queue stuff to a new header.
>
> We could technically break the new header up to avoid
> the sysfs.h include but it's so rarely included it
> doesn't seem to be worth it at this point.
>
> Reviewed-by: Amritha Nambiar<amritha.nambiar@intel.com>
> Signed-off-by: Jakub Kicinski<kuba@kernel.org>
> ---
Acked-by: Jesper Dangaard Brouer <hawk@kernel.org>
next prev parent reply other threads:[~2023-08-03 14:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 1:02 [PATCH bpf-next v2 0/3] net: struct netdev_rx_queue and xdp.h reshuffling Jakub Kicinski
2023-08-03 1:02 ` [PATCH bpf-next v2 1/3] eth: add missing xdp.h includes in drivers Jakub Kicinski
2023-08-03 14:09 ` Jesper Dangaard Brouer
2023-08-03 19:34 ` Horatiu Vultur
2023-08-03 1:02 ` [PATCH bpf-next v2 2/3] net: move struct netdev_rx_queue out of netdevice.h Jakub Kicinski
2023-08-03 14:24 ` Jesper Dangaard Brouer [this message]
2023-08-03 15:52 ` Alexander Lobakin
2023-08-03 1:02 ` [PATCH bpf-next v2 3/3] net: invert the netdevice.h vs xdp.h dependency Jakub Kicinski
2023-08-03 13:59 ` Jesper Dangaard Brouer
2023-08-03 15:50 ` [PATCH bpf-next v2 0/3] net: struct netdev_rx_queue and xdp.h reshuffling patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd6c0dee-3f2c-3613-a5ff-42cc11268e49@kernel.org \
--to=hawk@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=amritha.nambiar@intel.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=gregkh@linuxfoundation.org \
--cc=haoluo@google.com \
--cc=jasowang@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=jonathan.lemon@gmail.com \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=martin.lau@linux.dev \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=wangyufen@huawei.com \
--cc=xuanzhuo@linux.alibaba.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).