From: Shannon Nelson <snelson@pensando.io>
To: Jakub Kicinski <jakub.kicinski@netronome.com>,
Parav Pandit <parav@mellanox.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [PATCH v2 net-next 2/2] ionic: support sr-iov operations
Date: Thu, 12 Dec 2019 11:59:50 -0800 [thread overview]
Message-ID: <bd7553cd-8784-6dfd-0b51-552b49ca8eaa@pensando.io> (raw)
In-Reply-To: <20191212115228.2caf0c63@cakuba.netronome.com>
On 12/12/19 11:52 AM, Jakub Kicinski wrote:
> On Thu, 12 Dec 2019 06:53:42 +0000, Parav Pandit wrote:
>>> static void ionic_remove(struct pci_dev *pdev)
>>> {
>>> struct ionic *ionic = pci_get_drvdata(pdev);
>>> @@ -257,6 +338,9 @@ static void ionic_remove(struct pci_dev *pdev)
>>> if (!ionic)
>>> return;
>>>
>>> + if (pci_num_vf(pdev))
>>> + ionic_sriov_configure(pdev, 0);
>>> +
>> Usually sriov is left enabled while removing PF.
>> It is not the role of the pci PF removal to disable it sriov.
> I don't think that's true. I consider igb and ixgbe to set the standard
> for legacy SR-IOV handling since they were one of the first (the first?)
> and Alex Duyck wrote them.
>
> mlx4, bnxt and nfp all disable SR-IOV on remove.
This was my understanding as well, but now I can see that ixgbe and i40e
are both checking for existing VFs in probe and setting up to use them,
as well as the newer ice driver. I found this today by looking for
where they use pci_num_vf().
sln
next prev parent reply other threads:[~2019-12-12 19:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 0:33 [PATCH v2 net-next 0/2] ionic: add sriov support Shannon Nelson
2019-12-12 0:33 ` [PATCH v2 net-next 1/2] ionic: ionic_if bits for sr-iov support Shannon Nelson
2019-12-12 0:33 ` [PATCH v2 net-next 2/2] ionic: support sr-iov operations Shannon Nelson
2019-12-12 6:53 ` Parav Pandit
2019-12-12 19:52 ` Shannon Nelson
2019-12-12 19:52 ` Jakub Kicinski
2019-12-12 19:59 ` Shannon Nelson [this message]
2019-12-12 21:35 ` Jakub Kicinski
2019-12-12 22:24 ` Parav Pandit
2019-12-12 22:40 ` Shannon Nelson
2019-12-12 22:42 ` Jakub Kicinski
2019-12-16 4:47 ` Parav Pandit
2019-12-16 6:02 ` Shannon Nelson
2019-12-16 8:46 ` Parav Pandit
2020-01-03 0:05 ` Shannon Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd7553cd-8784-6dfd-0b51-552b49ca8eaa@pensando.io \
--to=snelson@pensando.io \
--cc=davem@davemloft.net \
--cc=jakub.kicinski@netronome.com \
--cc=netdev@vger.kernel.org \
--cc=parav@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).