From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03C09C43603 for ; Thu, 12 Dec 2019 19:59:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C979D2173E for ; Thu, 12 Dec 2019 19:59:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=pensando.io header.i=@pensando.io header.b="ZDwd0eXA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730742AbfLLT7w (ORCPT ); Thu, 12 Dec 2019 14:59:52 -0500 Received: from mail-pj1-f66.google.com ([209.85.216.66]:41111 "EHLO mail-pj1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730691AbfLLT7w (ORCPT ); Thu, 12 Dec 2019 14:59:52 -0500 Received: by mail-pj1-f66.google.com with SMTP id ca19so1528676pjb.8 for ; Thu, 12 Dec 2019 11:59:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=VNwuwgo+Bw+y37eqt7TiSvWfvx5rw5yWHq1LlUg874g=; b=ZDwd0eXALl6Hvq/HHpz3+ExQgUZ0Xwp9eQMgpzWKw8B6T1h9Y+CEys+lTybN7NVgQ/ WSc12EyescOP1k+5ggcUX3wiJIgEgXHkErW16tzLiALAqZn3ByNQB8eEiHAinFVpmbRD AG5jbq5pSsAKsQEMf/eEsqLRPRmM+gEi4/qFOy8HzwP67Mn8Q8cajZfPCmyzZBG0QZjn D1at8YmilanSqMacMfbGMLRWn3Oa07TNmOCllU3zZZeMpJTHbE3Ufd6Y/+GiXRYfr6Kg Z0UmHsEURKlMshxgzVKAL1EBkcJsR/BE1wCTBc7tzi/q9LQzPUZWq+zHMM+YSPm5MQoW ecug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=VNwuwgo+Bw+y37eqt7TiSvWfvx5rw5yWHq1LlUg874g=; b=rZDfHUBDL1mfKj/qgRXCXrAh7qRBzKG+KJs6rf+mxCf9dvscS+363JurGR6N2/frHe QUNDp7K+XE6Ywndbv59pcOnxibUxlg0/cXVbShfwrgt2YT5u12cmfgOZQgJuqXvhUCZ2 laSirTvi5loEccMohrNKt9mz9Xio/XmFm6Ak3ny75loXsuLCqPQrmTga4yQ2LziPj5Z9 s8gXBqh8ei7SGCpjvyVQi4JMcIks2n1HpYLVm/W6AFM2ccDnW3VFxh4N2adzU7atVrWb KpZMVmpQ484uQ5o9pLZsxyw+3ogUAX0EntoZ5DHRqdeYsfRhRTahDVJH+lLxRGbU3HuG 8ymQ== X-Gm-Message-State: APjAAAVwicVt7QA1zNXuSHma/dPeyRb76avc6ix2dRy36AdcnRHgZTez fEJTDVYWZbbvFWx0596qvSMVgg== X-Google-Smtp-Source: APXvYqwDqNszUsw5lg2HV64xQq+Ng7M6hNUregxKh54M/G7F2fQwJ6P3U+79wPqgTU4NJWLGOGb5gA== X-Received: by 2002:a17:90a:bd91:: with SMTP id z17mr11795939pjr.34.1576180791706; Thu, 12 Dec 2019 11:59:51 -0800 (PST) Received: from Shannons-MacBook-Pro.local (static-50-53-47-17.bvtn.or.frontiernet.net. [50.53.47.17]) by smtp.gmail.com with ESMTPSA id z19sm7870952pfn.49.2019.12.12.11.59.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Dec 2019 11:59:51 -0800 (PST) Subject: Re: [PATCH v2 net-next 2/2] ionic: support sr-iov operations To: Jakub Kicinski , Parav Pandit Cc: "netdev@vger.kernel.org" , "davem@davemloft.net" References: <20191212003344.5571-1-snelson@pensando.io> <20191212003344.5571-3-snelson@pensando.io> <20191212115228.2caf0c63@cakuba.netronome.com> From: Shannon Nelson Message-ID: Date: Thu, 12 Dec 2019 11:59:50 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: <20191212115228.2caf0c63@cakuba.netronome.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 12/12/19 11:52 AM, Jakub Kicinski wrote: > On Thu, 12 Dec 2019 06:53:42 +0000, Parav Pandit wrote: >>> static void ionic_remove(struct pci_dev *pdev) >>> { >>> struct ionic *ionic = pci_get_drvdata(pdev); >>> @@ -257,6 +338,9 @@ static void ionic_remove(struct pci_dev *pdev) >>> if (!ionic) >>> return; >>> >>> + if (pci_num_vf(pdev)) >>> + ionic_sriov_configure(pdev, 0); >>> + >> Usually sriov is left enabled while removing PF. >> It is not the role of the pci PF removal to disable it sriov. > I don't think that's true. I consider igb and ixgbe to set the standard > for legacy SR-IOV handling since they were one of the first (the first?) > and Alex Duyck wrote them. > > mlx4, bnxt and nfp all disable SR-IOV on remove. This was my understanding as well, but now I can see that ixgbe and i40e are both checking for existing VFs in probe and setting up to use them, as well as the newer ice driver.  I found this today by looking for where they use pci_num_vf(). sln