From: David Ahern <dsahern@kernel.org>
To: Niels Dossche <niels.dossche@ugent.be>,
"David S. Miller" <davem@davemloft.net>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ipv6: prevent a possible race condition with lifetimes
Date: Mon, 21 Feb 2022 20:02:35 -0700 [thread overview]
Message-ID: <bd7f34a6-4974-c3db-0d41-497168fcd944@kernel.org> (raw)
In-Reply-To: <5599cc3b-8925-4cfd-f035-ae3b87e821a3@ugent.be>
On 2/20/22 10:54 AM, Niels Dossche wrote:
> valid_lft, prefered_lft and tstamp are always accessed under the lock
> "lock" in other places. Reading these without taking the lock may result
> in inconsistencies regarding the calculation of the valid and preferred
> variables since decisions are taken on these fields for those variables.
>
> Signed-off-by: Niels Dossche <niels.dossche@ugent.be>
> ---
> net/ipv6/addrconf.c | 2 ++
> 1 file changed, 2 insertions(+)
>
Reviewed-by: David Ahern <dsahern@kernel.org>
next prev parent reply other threads:[~2022-02-22 3:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-20 17:54 [PATCH] ipv6: prevent a possible race condition with lifetimes Niels Dossche
2022-02-22 3:02 ` David Ahern [this message]
2022-02-23 0:43 ` Jakub Kicinski
2022-02-23 13:33 ` Niels Dossche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd7f34a6-4974-c3db-0d41-497168fcd944@kernel.org \
--to=dsahern@kernel.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=niels.dossche@ugent.be \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).