From: Eric Dumazet <eric.dumazet@gmail.com>
To: Neal Cardwell <ncardwell@google.com>, Eric Dumazet <edumazet@google.com>
Cc: David Miller <davem@davemloft.net>,
Netdev <netdev@vger.kernel.org>,
jean-louis@dupond.be, Yuchung Cheng <ycheng@google.com>,
Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH v2 net-next 4/4] tcp: implement coalescing on backlog queue
Date: Tue, 27 Nov 2018 14:13:00 -0800 [thread overview]
Message-ID: <bd893266-ecc5-9968-dc07-d52ff6b46df7@gmail.com> (raw)
In-Reply-To: <CADVnQym2b722Psew=4sgMhabyDWvv6YdSsk9q=6M09JXXSYJqA@mail.gmail.com>
On 11/27/2018 01:58 PM, Neal Cardwell wrote:
> I wonder if technically perhaps the logic should skip coalescing if
> the tail or skb has the TCP_FLAG_URG bit set? It seems if skbs are
> coalesced, and some have urgent data and some do not, then the
> TCP_FLAG_URG bit will be accumulated into the tail header, but there
> will be no way to ensure the correct urgent offsets for the one or
> more skbs with urgent data are passed along.
Yes, I guess I need to fix that, thanks.
I will simply make sure both thtail->urg and th->urg are not set.
I could only test thtail->urg, but that would require copying th->urg_ptr and th->urg,
and quite frankly we should not spend cycles on URG stuff.
next prev parent reply other threads:[~2018-11-28 9:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 15:57 [PATCH v2 net-next 0/4] tcp: take a bit more care of backlog stress Eric Dumazet
2018-11-27 15:57 ` [PATCH v2 net-next 1/4] tcp: hint compiler about sack flows Eric Dumazet
2018-11-27 21:03 ` Neal Cardwell
2018-11-27 15:57 ` [PATCH v2 net-next 2/4] tcp: take care of compressed acks in tcp_add_reno_sack() Eric Dumazet
2018-11-27 21:19 ` Neal Cardwell
2018-11-27 21:54 ` Eric Dumazet
2018-11-27 15:57 ` [PATCH v2 net-next 3/4] tcp: make tcp_space() aware of socket backlog Eric Dumazet
2018-11-27 21:22 ` Neal Cardwell
2018-11-27 15:57 ` [PATCH v2 net-next 4/4] tcp: implement coalescing on backlog queue Eric Dumazet
2018-11-27 21:58 ` Neal Cardwell
2018-11-27 22:13 ` Eric Dumazet [this message]
2018-11-27 22:32 ` Eric Dumazet
2018-11-27 17:50 ` [PATCH v2 net-next 0/4] tcp: take a bit more care of backlog stress Yuchung Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd893266-ecc5-9968-dc07-d52ff6b46df7@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jean-louis@dupond.be \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).