From: Eric Dumazet <eric.dumazet@gmail.com>
To: Song Liu <songliubraving@fb.com>, netdev@vger.kernel.org
Cc: daniel@iogearbox.net, kernel-team@fb.com,
Willem de Bruijn <willemb@google.com>,
Petar Penkov <ppenkov@google.com>
Subject: Re: [PATCH bpf-next] bpf: test_bpf: add dummy dev->net for flow_dissector
Date: Thu, 27 Sep 2018 05:36:27 -0700 [thread overview]
Message-ID: <bda9ab7e-e92e-488b-5d9e-aef839e79941@gmail.com> (raw)
In-Reply-To: <20180927071533.2290229-1-songliubraving@fb.com>
On 09/27/2018 12:15 AM, Song Liu wrote:
> Latest changes in __skb_flow_dissect() assume skb->dev has valid nd_net.
> However, this is not true for test_bpf. As a result, test_bpf.ko crashes
> the system with the following stack trace:
>
>
> This patch fixes tes_bpf by adding a dummy struct net to the dummy dev.
>
> Fixes: d0e13a1488ad ("flow_dissector: lookup netns by skb->sk if skb->dev is NULL")
> Fixes: d58e468b1112 ("flow_dissector: implements flow dissector BPF hook")
> Cc: Willem de Bruijn <willemb@google.com>
> Cc: Petar Penkov <ppenkov@google.com>
> Signed-off-by: Song Liu <songliubraving@fb.com>
Reported-by: Eric Dumazet <edumazet@google.com>
Thanks.
next prev parent reply other threads:[~2018-09-27 18:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-27 7:15 [PATCH bpf-next] bpf: test_bpf: add dummy dev->net for flow_dissector Song Liu
2018-09-27 12:36 ` Eric Dumazet [this message]
2018-09-27 12:58 ` Eric Dumazet
2018-09-27 14:11 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bda9ab7e-e92e-488b-5d9e-aef839e79941@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=ppenkov@google.com \
--cc=songliubraving@fb.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).