From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793268851; b=KULsyS5TrnQiLeyrqcaGszosfTSTNYXkebZHn7435jD5JH0Iu8WNjegDw2OjQiPxPsC0 tqFbw/dJslImgWpAHPqoAZLLwgKMfmggpAOqysE9S24ZRq+UQLUBXovq+6wIwPQnFGHne cwPLEAGVXpcaIfhS3ue/Pr5L6PJe3scI10Gu8FgKLCbWZ36TJKbelinkhCjw/3tU+BAR9 aRfUytkY8RfmsVKDF3+igGA1ayXLIkIxRwo1PLC7PMYQV8zOvhzPbi7mWXg13gGR0xtGR SSnHMqTVGQPNS2FweIUgoxlXMRTnk0aABeCPbNs5lbONntaioP7PW5B5zxPXrZTIJEw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793268851; h=DMARC-Filter:DKIM-Signature:Received:X-MC-Unique: X-Mimecast-MFC-AGG-ID:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received: X-Received:Received:Message-ID:Date:MIME-Version:User-Agent:Subject: To:Cc:References:Content-Language:From:In-Reply-To:Content-Type: Content-Transfer-Encoding; bh=g6ZvoJA1lnqkwFVkrQz/iNNGer9RaAvDbUj4LHUnhUI=; b=xcDi1VUpkmiyOP+s1fltx1ooR9lPBNCkd6u960Iy0EmTARrbjNP+Zs0YaOft/mupUjvP 4IzSoYQpavWDtlm0qjqNJJ6rsdC3h2f4WzHeUFFVws4v21CxjWp6ozLCYtxDBsJepunkA /cfrc5/R2rdBnP/ia8+iVbYuMszMFJNnilfnKUkrWkaF4GLp+G0iyeOOVGUEG0W0vRl5A GxFdPWDWA04VqIMOqNeW1kXnkhQrAE5FqmCceHqkShdEQtK+is0a6i4/f/dlbzAIvxF4r LKX7Ljd64azQvY5EMp5ZsDioSHloO8DNLdymWNkf+Es7Ri6rtpW7SzNOaX9VbagW59w== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=XPn6YHW9; dkim=pass header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=google header.b=h7ylYXOz; arc=none smtp.remote-ip=170.10.129.124 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49CAA606A31C for ; Thu, 29 Oct 2026 10:14:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 49CAA606A31C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=XPn6YHW9; dkim=pass (2048-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=google header.b=h7ylYXOz DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1793268847; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g6ZvoJA1lnqkwFVkrQz/iNNGer9RaAvDbUj4LHUnhUI=; b=XPn6YHW9DhQDS2o01aDR7o0dCOnq6CquwPB4VX55o1hUbxdWsfheCQhMdnVytLhkeNBxIk qxRTdx0ETjekO7E/HdDs++jhLVLjz8XT7ZMHX3qZt3uC28+tjlBU03IFenZ2OHNlxssXhQ yTfS7NJGpImf7kTMHt/t+5gDhnQpfCo= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-395-UYjbCmGKOeCnTDMaR6cv1A-1; Thu, 29 Oct 2026 06:14:05 -0400 X-MC-Unique: UYjbCmGKOeCnTDMaR6cv1A-1 X-Mimecast-MFC-AGG-ID: UYjbCmGKOeCnTDMaR6cv1A_1793268845 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4a1fdde384cso13400355e9.3 for ; Thu, 29 Oct 2026 03:14:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1793268844; x=1793873644; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=g6ZvoJA1lnqkwFVkrQz/iNNGer9RaAvDbUj4LHUnhUI=; b=h7ylYXOz2UEdPWY1fYVL5jqH4FnZo3/o7js8VE+c/8/gAN938wWuh3nsk052MoH7p4 VUo348ObDvXdzkJm0/SeUzsJ5m/fx0WbXiyB2sWmuKip59WMuap8Ih7pNkz/tUElCCkg r1hZtXwv0F5wdnwfFGzkdFpJnwS5w+U1E5iabmrHmThpkUTw4/6uDvm1ZTzdQdGOkNQw f29jlZccEfymQux3/Lq0XpMLvscWSlGh0BrIfiiuxxTW+NMMT9NmOqMjXlj25njsrJTm Tl/J9cGN1L3z7lzyz0Or4HMAG5vZS9W8A7pT2CPkr4scbUY1sDx8nQApFziLLPZLQpPH 9lpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793268844; x=1793873644; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=g6ZvoJA1lnqkwFVkrQz/iNNGer9RaAvDbUj4LHUnhUI=; b=Hp1CuxWHb+4hywNZULjzuIZDCTgsomLNfbt88F2513GrzKGwMoGhdji7k2IFD3q46a +8M/gsI7AXQ/3SWggUOq4KYDJYtORO+guwllSGNBHJnb6mxXTS6ltGSD8+DbwKz6e+be VlnGRu5phk2ZJq6nx9bSNrnO0zqAwyx7oknB8Q7SojWqlyf2CI5/aL3i41SApyqdIJWb gqIDRQpmKRHaryRwSB2cJD/vXjctY21cjtTaQXAfuOI3MGIdoNxS/SsQHm7f2zF9uBoi BcwU7GB+SRiZrnzf2NRVjuHx2CiZimYRWQOvP7ZLx3JrkCyW8Z8H9RhzrGkp4EH6aOrW 0WYA== X-Forwarded-Encrypted: i=1; AKwUvBybmNg0GkbZioo7FYmTXlLrvl9dhBQimQFzy0cIeeukrsBAigCO9/OH6zTkVuZNZqBOhFRq8h4=@vger.kernel.org X-Gm-Message-State: AFq9FYIrviuTOpoQI60TWLcI2+DyRQsX/GuRLN0VVP0XGb+HmLIdrTwI R59hexjrxjvEw7OkoU86MSyxCJJBz7twSBqeNAk/+wymLAhT9aMQqAGr+OwmmXxt1H1Hxnz/kgZ Xl47ir7FfY0OeMx3VksHly86PGnN18FjGANAYfRVTA9RMuyhKKar/oifJOg== X-Gm-Gg: AYBFou1ffLrgm9UJGcoc4anxXtK+1L4NCIZ5Ot1KsVr2OW5MPWNQ4m0x+1eQLutPjJK SxUpwVBfh6/gsqoNxkBRRBNk6qRz3PydEZxTV3yc/HY/cNiIP/NwGD9xlHP+lUZ77KkMf5Ue4DN 4YP+VE+WQgJmGPl8KnPYTAvvKbgaLns2iGmMyTZ3n/xD6FmLQOhEYnAy0cLDLTv3JqCESz5Qxls Nf7YSyRagSQE/uc2/T5rpb1ysqGF+ryThkhn4ZAOiZPTvD0DxpOyzCfTDQmtNUQ6nvjdX8NX8CN QcMTXrNA2pZ6rMkgBGk0H6sYc14Je+32S3TB6aiv7cX1DMcwNS/lX5JLQ8XBFutSRvp3vdUtpm3 ZClUCQfXaJdK2pePfHNATz+feQiQHklWGpoqSuIf2G1oDYKLOjUpEfldxnOetJ/ahFJckOzlEPG 0oJ2Ptnqmkt004DnJwcuFuOnGb+OCCsIQ+510wJ+Y3E559peI= X-Received: by 2002:a05:600c:870f:b0:4a1:fcfa:2a07 with SMTP id 5b1f17b1804b1-4a967f84822mr125620625e9.30.1793268844559; Thu, 29 Oct 2026 03:14:04 -0700 (PDT) X-Received: by 2002:a05:600c:870f:b0:4a1:fcfa:2a07 with SMTP id 5b1f17b1804b1-4a967f84822mr125619965e9.30.1793268844145; Thu, 29 Oct 2026 03:14:04 -0700 (PDT) Received: from [192.168.188.234] (ip174-129-192-82.pool-bba.aruba.it. [82.192.129.174]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48e3ecdd5b3sm33496102f8f.53.2026.10.29.03.14.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Oct 2026 03:14:03 -0700 (PDT) Message-ID: Date: Thu, 29 Oct 2026 11:14:01 +0100 X-Mailing-List: netdev@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v4 2/2] net: stmmac: Stop Tx queue when (en|dis)abling XSK pools To: netdev-bot+sashiko@kernel.org, kurt@linutronix.de Cc: maxime.chevallier@bootlin.com, andrew+netdev@lunn.ch, davem@davemloft.net, kuba@kernel.org, edumazet@kernel.org, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, ast@kernel.org, daniel@iogearbox.net, hawk@kernel.org, john.fastabend@gmail.com, sdf@fomichev.me, yoong.siang.song@intel.com, faizal.abdul.rahim@intel.com, boon.leong.ong@intel.com, bigeasy@linutronix.de, maciej.fijalkowski@intel.com, nb@tipi-net.de, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, bpf@vger.kernel.org References: <20261022-stmmac_xsk_crashes-v4-2-15c0c750bb96@linutronix.de> <179299947058.3134.16617492920924670801@kernel.org> Content-Language: en-US From: Paolo Abeni In-Reply-To: <179299947058.3134.16617492920924670801@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 10/26/26 08:24, netdev-bot+sashiko@kernel.org wrote: > - [High] stmmac_xdp_enable_pool() (stmmac_xdp.c:59) and > stmmac_xdp_disable_pool() (stmmac_xdp.c:102) now call… > - [Medium] The patch only works if __QUEUE_STATE_DRV_XOFF stays set from > stmmac_xdp_stop_tx_queue() until the ring is rebuilt. > - [Medium] In stmmac_xdp_xmit_xdpf(), first_entry and entry are read from > tx_q->cur_tx when the locals are declared (stmmac_main.c:5263-5264). I understand that the comments raised on patch 1/2 are sort of pre-existing, as the reported races can be reached by __stmmac_release(), but the above ones look legit and unaddressed/unanswered. You can target `net` with the next revision, and please reply also to already discussed comments, even with just a pointer to the previous discussion. /P