From: "Nambiar, Amritha" <amritha.nambiar@intel.com>
To: Jakub Kicinski <kuba@kernel.org>, <oe-kbuild-all@lists.linux.dev>
Cc: kernel test robot <lkp@intel.com>, <netdev@vger.kernel.org>,
<pabeni@redhat.com>
Subject: Re: [net-next PATCH v5 01/10] netdev-genl: spec: Extend netdev netlink spec in YAML for queue
Date: Fri, 20 Oct 2023 17:37:46 -0700 [thread overview]
Message-ID: <bdd45dde-18ce-4dec-815e-04959912332d@intel.com> (raw)
In-Reply-To: <20231020150557.00af950d@kernel.org>
On 10/20/2023 3:05 PM, Jakub Kicinski wrote:
> On Fri, 20 Oct 2023 13:26:38 -0700 Nambiar, Amritha wrote:
>>> WARNING:SPACING: space prohibited between function name and open parenthesis '('
>>> #547: FILE: tools/net/ynl/generated/netdev-user.h:181:
>>> + struct netdev_queue_get_rsp obj __attribute__ ((aligned (8)));
>>
>> Looks like the series is in "Changes Requested" state following these
>> warnings. Is there any recommendation for warnings on generated code? I
>> see similar issues on existing code in the generated file.
>
> Yes, ignore this one. I'll post a change to the codegen.
> The warning on patch 3 is legit, right?
>
Thanks for the fix to codegen.
Yes, the warning on patch 3 is legit. I'll fix it up in the next version
together with addressing other review feedback on this v5 series.
> kernel test bot folks, please be careful with the checkpatch warnings.
> Some of them are bogus. TBH I'm not sure how much value running
> checkpatch in the bot adds. It's really trivial to run for the
> maintainers when applying patches.
>
next prev parent reply other threads:[~2023-10-21 0:38 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-19 0:06 [net-next PATCH v5 00/10] Introduce queue and NAPI support in netdev-genl (Was: Introduce NAPI queues support) Amritha Nambiar
2023-10-19 0:06 ` [net-next PATCH v5 01/10] netdev-genl: spec: Extend netdev netlink spec in YAML for queue Amritha Nambiar
2023-10-19 2:12 ` kernel test robot
2023-10-20 20:26 ` Nambiar, Amritha
2023-10-20 22:05 ` Jakub Kicinski
2023-10-21 0:37 ` Nambiar, Amritha [this message]
2023-10-21 1:53 ` Philip Li
2023-10-23 14:52 ` Jakub Kicinski
2023-10-23 19:09 ` Nambiar, Amritha
2023-10-23 22:39 ` Jakub Kicinski
2023-10-24 1:02 ` Philip Li
2023-10-24 1:44 ` Jakub Kicinski
2023-10-24 2:00 ` Philip Li
2023-10-19 0:06 ` [net-next PATCH v5 02/10] net: Add queue and napi association Amritha Nambiar
2023-10-19 0:06 ` [net-next PATCH v5 03/10] ice: Add support in the driver for associating queue with napi Amritha Nambiar
2023-10-19 5:18 ` kernel test robot
2023-10-19 0:06 ` [net-next PATCH v5 04/10] netdev-genl: Add netlink framework functions for queue Amritha Nambiar
2023-10-19 0:06 ` [net-next PATCH v5 05/10] netdev-genl: spec: Extend netdev netlink spec in YAML for NAPI Amritha Nambiar
2023-10-19 2:12 ` kernel test robot
2023-10-19 0:06 ` [net-next PATCH v5 06/10] netdev-genl: Add netlink framework functions for napi Amritha Nambiar
2023-10-19 0:06 ` [net-next PATCH v5 07/10] netdev-genl: spec: Add irq in netdev netlink YAML spec Amritha Nambiar
2023-10-19 0:06 ` [net-next PATCH v5 08/10] net: Add NAPI IRQ support Amritha Nambiar
2023-10-19 0:06 ` [net-next PATCH v5 09/10] netdev-genl: spec: Add PID in netdev netlink YAML spec Amritha Nambiar
2023-10-19 0:06 ` [net-next PATCH v5 10/10] netdev-genl: Add PID for the NAPI thread Amritha Nambiar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bdd45dde-18ce-4dec-815e-04959912332d@intel.com \
--to=amritha.nambiar@intel.com \
--cc=kuba@kernel.org \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).