From: Waiman Long <longman@redhat.com>
To: Jiri Benc <jbenc@redhat.com>
Cc: netdev@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
pravin shelar <pshelar@ovn.org>
Subject: Re: [PATCH net 1/2] vxlan: fix hlist corruption
Date: Mon, 3 Jul 2017 09:25:45 -0400 [thread overview]
Message-ID: <bdd5d0e8-b8fa-2c81-07ad-17ad89b6c052@redhat.com> (raw)
In-Reply-To: <20170703102359.246d68a2@griffin>
On 07/03/2017 04:23 AM, Jiri Benc wrote:
> On Sun, 2 Jul 2017 16:06:10 -0400, Waiman Long wrote:
>> I didn't see any init code for hlist4 and hlist6. Is vxlan_dev going to
>> be *zalloc'ed so that they are guaranteed to be NULL? If not, you may
>> need to add init code as not both hlists will be hashed and so one of
>> them may contain invalid data.
> Yes, it's zalloced via alloc_netdev. No need to init the fields
> explicitly.
>
> Jiri
Thanks for the clarification.
-Longman
next prev parent reply other threads:[~2017-07-03 13:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-02 17:00 [PATCH net 0/2] vxlan, geneve: fix hlist corruption Jiri Benc
2017-07-02 17:00 ` [PATCH net 1/2] vxlan: " Jiri Benc
2017-07-02 20:06 ` Waiman Long
2017-07-03 8:23 ` Jiri Benc
2017-07-03 13:25 ` Waiman Long [this message]
2017-07-02 17:00 ` [PATCH net 2/2] geneve: " Jiri Benc
2017-07-03 9:37 ` [PATCH net 0/2] vxlan, " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bdd5d0e8-b8fa-2c81-07ad-17ad89b6c052@redhat.com \
--to=longman@redhat.com \
--cc=jbenc@redhat.com \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@ovn.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).