From: Charles McLachlan <cmclachlan@solarflare.com>
To: Jesper Dangaard Brouer <brouer@redhat.com>
Cc: <davem@davemloft.net>, <netdev@vger.kernel.org>,
<linux-net-drivers@solarflare.com>
Subject: Re: [PATCH net-next 2/6] sfc: perform XDP processing on received packets.
Date: Thu, 24 Oct 2019 15:45:57 +0100 [thread overview]
Message-ID: <bdf2137e-808e-2607-0c65-e609741242c0@solarflare.com> (raw)
In-Reply-To: <20191023004501.4a78c300@carbon>
On 22/10/2019 23:45, Jesper Dangaard Brouer wrote:
>> + case XDP_REDIRECT:
>> + rc = xdp_do_redirect(efx->net_dev, &xdp, xdp_prog);
>> + if (rc) {
>
> Can we call the 'rc' variable 'err' instead?
> And give it an unlikely().
Yes. Done in next version of the patch set.
next prev parent reply other threads:[~2019-10-24 14:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-22 14:53 [PATCH net-next 0/6] sfc: Add XDP support Charles McLachlan
2019-10-22 15:37 ` [PATCH net-next 1/6] sfc: support encapsulation of xdp_frames in efx_tx_buffer Charles McLachlan
2019-10-22 22:19 ` Jesper Dangaard Brouer
2019-10-24 14:44 ` Charles McLachlan
2019-10-22 15:38 ` [PATCH net-next 2/6] sfc: perform XDP processing on received packets Charles McLachlan
2019-10-22 16:26 ` Edward Cree
2019-10-24 14:42 ` Charles McLachlan
2019-10-22 22:45 ` Jesper Dangaard Brouer
2019-10-24 14:45 ` Charles McLachlan [this message]
2019-10-22 15:38 ` [PATCH net-next 3/6] sfc: Enable setting of xdp_prog Charles McLachlan
2019-10-22 15:38 ` [PATCH net-next 4/6] sfc: allocate channels for XDP tx queues Charles McLachlan
2019-10-22 15:39 ` [PATCH net-next 5/6] sfc: handle XDP_TX outcomes of XDP eBPF programs Charles McLachlan
2019-10-22 15:39 ` [PATCH net-next 6/6] sfc: add XDP counters to ethtool stats Charles McLachlan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bdf2137e-808e-2607-0c65-e609741242c0@solarflare.com \
--to=cmclachlan@solarflare.com \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=linux-net-drivers@solarflare.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).