From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Andy Gospodarek" Subject: Re: [Bugme-new] [Bug 9543] New: RTNL: assertion failed at net/ipv6/addrconf.c (2164)/RTNL: assertion failed at net/ipv4/devinet.c (1055) Date: Sat, 15 Dec 2007 10:09:28 -0500 Message-ID: References: <28503.1197481615@death> <20071214182638.GC25879@gospo.usersys.redhat.com> <20071214224722.GA8728@gospo.usersys.redhat.com> <20071215041052.GA25324@gondor.apana.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "Krzysztof Oledzki" , "Jay Vosburgh" , "Andrew Morton" , bugme-daemon@bugzilla.kernel.org, shemminger@linux-foundation.org, davem@davemloft.net, netdev@vger.kernel.org To: "Herbert Xu" Return-path: Received: from fk-out-0910.google.com ([209.85.128.190]:15554 "EHLO fk-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757677AbXLOPJb (ORCPT ); Sat, 15 Dec 2007 10:09:31 -0500 Received: by fk-out-0910.google.com with SMTP id z23so409721fkz.5 for ; Sat, 15 Dec 2007 07:09:30 -0800 (PST) In-Reply-To: <20071215041052.GA25324@gondor.apana.org.au> Content-Disposition: inline Sender: netdev-owner@vger.kernel.org List-ID: On Dec 14, 2007 11:10 PM, Herbert Xu wrote: > On Fri, Dec 14, 2007 at 05:47:22PM -0500, Andy Gospodarek wrote: > > > > I'm guessing if we go back to using a write-lock for bond->lock this > > will go back to working again, but I'm not totally convinced since there > > are plenty of places where we used a read-lock with it. > > Sorry I forgot to cc you earlier Andy. > > But to fix this you need make sure that all read locks on bond->lock > in process context disable BH. This is because at least one write > lock can be taken from BH context. I agree with you completely, Herbet, which is why I was surprised that my first apparently did not resolve the issue. I felt it should have.... > You don't need to turn the read locks into write locks however. > > This is also something that we can undo once the set_multicast > interface has been fixed to not take the tx lock. > > Cheers, > -- > Visit Openswan at http://www.openswan.org/ > Email: Herbert Xu ~{PmV>HI~} > Home Page: http://gondor.apana.org.au/~herbert/ > PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt >