Netdev List
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Benno Lossin <benno.lossin@proton.me>
Cc: FUJITA Tomonori <fujita.tomonori@gmail.com>,
	netdev@vger.kernel.org, rust-for-linux@vger.kernel.org,
	tmgross@umich.edu, miguel.ojeda.sandonis@gmail.com,
	aliceryhl@google.com
Subject: Re: [PATCH net-next v4 6/6] net: phy: add Applied Micro QT2025 PHY driver
Date: Sun, 18 Aug 2024 19:39:24 +0200	[thread overview]
Message-ID: <bdfdac7c-edb0-4b78-b616-76be287c7597@lunn.ch> (raw)
In-Reply-To: <0797f8e8-ea3c-413d-b782-84dd97919ea9@proton.me>

> Then you get this error:
> 
>     error: unused `core::result::Result` that must be used
>       --> drivers/net/phy/qt2025.rs:88:9
>        |
>     88 |         dev.genphy_read_status::<C45>();
>        |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>        |
>        = note: this `Result` may be an `Err` variant, which should be handled
>        = note: `-D unused-must-use` implied by `-D warnings`
>        = help: to override `-D warnings` add `#[allow(unused_must_use)]`
>     help: use `let _ = ...` to ignore the resulting value
>        |
>     88 |         let _ = dev.genphy_read_status::<C45>();
>        |         +++++++

O.K, so the compiler tells you, which is great. The C compiler would
not, which is why i tend to think of these things.

	Andrew

  reply	other threads:[~2024-08-18 17:39 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-17  5:19 [PATCH net-next v4 0/6] net: phy: add Applied Micro QT2025 PHY driver FUJITA Tomonori
2024-08-17  5:19 ` [PATCH net-next v4 1/6] rust: sizes: add commonly used constants FUJITA Tomonori
2024-08-17  5:53   ` Benno Lossin
2024-08-17  5:19 ` [PATCH net-next v4 2/6] rust: net::phy support probe callback FUJITA Tomonori
2024-08-17  5:59   ` Benno Lossin
2024-08-17  5:19 ` [PATCH net-next v4 3/6] rust: net::phy implement AsRef<kernel::device::Device> trait FUJITA Tomonori
2024-08-17 13:30   ` Benno Lossin
2024-08-18  2:13     ` FUJITA Tomonori
2024-08-18  6:01       ` Benno Lossin
2024-08-18  7:36         ` FUJITA Tomonori
2024-08-18  9:03           ` Benno Lossin
2024-08-18  9:15             ` FUJITA Tomonori
2024-08-18 10:42               ` Benno Lossin
2024-08-18 11:25                 ` FUJITA Tomonori
2024-08-18 15:55                   ` Benno Lossin
2024-08-18 15:38             ` Andrew Lunn
2024-08-18 15:45               ` Greg KH
2024-08-18 15:54                 ` Benno Lossin
2024-08-18 16:16                   ` Andrew Lunn
2024-08-18 16:19                     ` Benno Lossin
2024-08-17  5:19 ` [PATCH net-next v4 4/6] rust: net::phy unified read/write API for C22 and C45 registers FUJITA Tomonori
2024-08-17 18:43   ` Andrew Lunn
2024-08-17  5:19 ` [PATCH net-next v4 5/6] rust: net::phy unified genphy_read_status function " FUJITA Tomonori
2024-08-17 18:44   ` Andrew Lunn
2024-08-17  5:19 ` [PATCH net-next v4 6/6] net: phy: add Applied Micro QT2025 PHY driver FUJITA Tomonori
2024-08-17 18:51   ` Andrew Lunn
2024-08-17 21:34     ` Benno Lossin
2024-08-18 15:44       ` Andrew Lunn
2024-08-18 16:16         ` Benno Lossin
2024-08-18 17:39           ` Andrew Lunn [this message]
2024-08-19  0:22             ` Miguel Ojeda
2024-08-18 16:10   ` Benno Lossin
2024-08-18 23:38     ` FUJITA Tomonori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bdfdac7c-edb0-4b78-b616-76be287c7597@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=aliceryhl@google.com \
    --cc=benno.lossin@proton.me \
    --cc=fujita.tomonori@gmail.com \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tmgross@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox