From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F26ECA46 for ; Fri, 20 Oct 2023 06:56:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="h/zZ9RXb" Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2537B1A8 for ; Thu, 19 Oct 2023 23:56:21 -0700 (PDT) Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-40853c639abso511895e9.0 for ; Thu, 19 Oct 2023 23:56:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1697784979; x=1698389779; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=I9LEiI73HKl/yMmpsQOiFinCN5KnlO7an5SddP9Ej00=; b=h/zZ9RXbaO6rAMYh0u9MNKdaz1N2GUNDrj0mfc9tH9JPEDqCCTixPhr71XprBswFpU zw1UDvRG1gxZjStRUOUJ22FxlnDBF1cdw0aY6vLGihvZVTbAXxRSl4I6J4Q7S4noXN2s ivtewT2w6+s4XOX1A43g8i1gjRwINtvhtRpvXg55ON5YvbqBfMIc8gvJqxhwopN/F18z a8gkfuK5yM1Zr4H0dH1Q/30ICWdmJtInyuaRboQxhuC5DfU7SndpLWEaC16Ks3+B3Rvt iCIrUzRBvNw9pLmh9lnHbt/wwPBaiKDI4g/r97X0LhRv15n4Xn+n5KkzPno1g83eh5gQ WLjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697784979; x=1698389779; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=I9LEiI73HKl/yMmpsQOiFinCN5KnlO7an5SddP9Ej00=; b=l9IWd+GXDUqs2WdEHBEiMhVnKzaHqN9JC1VHtwSE5I3yf3eUOsgT2w3bnRT3Da0IWG NgFKVXd96CbaFt8CmMRdK4hv8JL66kO66BoSAbK4qH9hxWee3zGXGXlTYhbuA4ZCT4ix YxcQGKD2fvY90T9BqHpp7JXtuCehOtajPi16jRWWwL43PRGr+4eEF5qNF6gB5jv52Rob t47gZSHGgp03w5tauduJ11jXyxAA3cWFIepr/wJGTB/F7DAzYF6wiD8kYJxPlFOfdyK6 qkHo/IpKj1JoJKbuXfDjySL9dgVbkzyYA0rFNxoDLyROw15vl+9HxVgHRTotpC9tmLA1 SXmQ== X-Gm-Message-State: AOJu0Yx/NkN5SNBK0dXVXg19WVpXH/vPTfZyROVX0zVNX6KeBozM3rSQ uPV8GDbTi1HEpewl3ADvtpYG0g== X-Google-Smtp-Source: AGHT+IEvEEtQGpyk+q26WaO58peFpV+y2bXO492uWGPLm75ilrOY/3/PfE6IuqfhDBM16huGVo92EA== X-Received: by 2002:a05:600c:4f12:b0:408:3696:3d51 with SMTP id l18-20020a05600c4f1200b0040836963d51mr833558wmq.4.1697784979490; Thu, 19 Oct 2023 23:56:19 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id ay10-20020a05600c1e0a00b00405442edc69sm3580447wmb.14.2023.10.19.23.56.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 23:56:19 -0700 (PDT) Date: Fri, 20 Oct 2023 09:56:16 +0300 From: Dan Carpenter To: Su Hui Cc: jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH v2] i40e: add an error code check in i40e_vsi_setup Message-ID: References: <20231020024308.46630-1-suhui@nfschina.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231020024308.46630-1-suhui@nfschina.com> On Fri, Oct 20, 2023 at 10:43:09AM +0800, Su Hui wrote: > check the value of 'ret' after calling 'i40e_vsi_config_rss'. > > Signed-off-by: Su Hui > --- > v2: > - call i40e_vsi_clear_rings() to free rings(thank dan carpenter for > pointing out this). Looks okay now. Reviewed-by: Dan Carpenter regards, dan carpenter