* [PATCH] cxgb4: fix abort_req_rss6 struct
@ 2018-08-31 18:52 Steve Wise
2018-09-02 5:28 ` David Miller
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Steve Wise @ 2018-08-31 18:52 UTC (permalink / raw)
To: netdev; +Cc: jgg, dledford, davem, linux-rdma
Remove the incorrect WR_HDR field which can cause a misinterpretation
of this CPL by ULDs.
Fixes: a3cdaa69e4ae ("cxgb4: Adds CPL support for Shared Receive Queues")
Signed-off-by: Steve Wise <swise@opengridcomputing.com>
---
Dave, Doug, and Jason,
I request this merge through the rdma repo since the only user of this
structure is iw_cxgb4.
---
drivers/net/ethernet/chelsio/cxgb4/t4_msg.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/chelsio/cxgb4/t4_msg.h b/drivers/net/ethernet/chelsio/cxgb4/t4_msg.h
index b8f75a22fb6c..f152da1ce046 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/t4_msg.h
+++ b/drivers/net/ethernet/chelsio/cxgb4/t4_msg.h
@@ -753,7 +753,6 @@ struct cpl_abort_req_rss {
};
struct cpl_abort_req_rss6 {
- WR_HDR;
union opcode_tid ot;
__be32 srqidx_status;
};
--
1.8.3.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] cxgb4: fix abort_req_rss6 struct
2018-08-31 18:52 [PATCH] cxgb4: fix abort_req_rss6 struct Steve Wise
@ 2018-09-02 5:28 ` David Miller
2018-09-05 22:55 ` Jason Gunthorpe
2018-09-11 15:19 ` Jason Gunthorpe
2 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2018-09-02 5:28 UTC (permalink / raw)
To: swise; +Cc: netdev, jgg, dledford, linux-rdma
From: Steve Wise <swise@opengridcomputing.com>
Date: Fri, 31 Aug 2018 11:52:00 -0700
> Remove the incorrect WR_HDR field which can cause a misinterpretation
> of this CPL by ULDs.
>
> Fixes: a3cdaa69e4ae ("cxgb4: Adds CPL support for Shared Receive Queues")
> Signed-off-by: Steve Wise <swise@opengridcomputing.com>
> ---
>
> Dave, Doug, and Jason,
>
> I request this merge through the rdma repo since the only user of this
> structure is iw_cxgb4.
No objections from me.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] cxgb4: fix abort_req_rss6 struct
2018-08-31 18:52 [PATCH] cxgb4: fix abort_req_rss6 struct Steve Wise
2018-09-02 5:28 ` David Miller
@ 2018-09-05 22:55 ` Jason Gunthorpe
2018-09-10 15:16 ` Steve Wise
2018-09-11 15:19 ` Jason Gunthorpe
2 siblings, 1 reply; 5+ messages in thread
From: Jason Gunthorpe @ 2018-09-05 22:55 UTC (permalink / raw)
To: Steve Wise; +Cc: netdev, dledford, davem, linux-rdma
On Fri, Aug 31, 2018 at 11:52:00AM -0700, Steve Wise wrote:
> Remove the incorrect WR_HDR field which can cause a misinterpretation
> of this CPL by ULDs.
What does that mean?
Is this an -rc patch?
Jason
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] cxgb4: fix abort_req_rss6 struct
2018-09-05 22:55 ` Jason Gunthorpe
@ 2018-09-10 15:16 ` Steve Wise
0 siblings, 0 replies; 5+ messages in thread
From: Steve Wise @ 2018-09-10 15:16 UTC (permalink / raw)
To: Jason Gunthorpe; +Cc: netdev, dledford, davem, linux-rdma
(sorry for the late reply, I was out all last week)
On 9/5/2018 5:55 PM, Jason Gunthorpe wrote:
> On Fri, Aug 31, 2018 at 11:52:00AM -0700, Steve Wise wrote:
>> Remove the incorrect WR_HDR field which can cause a misinterpretation
>> of this CPL by ULDs.
>
> What does that mean?
>
It means iw_cxgb4 doesn't correctly handle incoming ABORT CPL messages
due to this incorrect struct.
> Is this an -rc patch?
>
Yes. Since it fixes a3cdaa69e4ae ("cxgb4: Adds CPL support for Shared
Receive Queues") which went into 4.19.
Steve.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] cxgb4: fix abort_req_rss6 struct
2018-08-31 18:52 [PATCH] cxgb4: fix abort_req_rss6 struct Steve Wise
2018-09-02 5:28 ` David Miller
2018-09-05 22:55 ` Jason Gunthorpe
@ 2018-09-11 15:19 ` Jason Gunthorpe
2 siblings, 0 replies; 5+ messages in thread
From: Jason Gunthorpe @ 2018-09-11 15:19 UTC (permalink / raw)
To: Steve Wise; +Cc: netdev, dledford, davem, linux-rdma
On Fri, Aug 31, 2018 at 11:52:00AM -0700, Steve Wise wrote:
> Remove the incorrect WR_HDR field which can cause a misinterpretation
> of this CPL by ULDs.
>
> Fixes: a3cdaa69e4ae ("cxgb4: Adds CPL support for Shared Receive Queues")
> Signed-off-by: Steve Wise <swise@opengridcomputing.com>
> ---
>
> Dave, Doug, and Jason,
>
> I request this merge through the rdma repo since the only user of this
> structure is iw_cxgb4.
Applied to for-rc, thanks
Jason
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-09-11 20:19 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-31 18:52 [PATCH] cxgb4: fix abort_req_rss6 struct Steve Wise
2018-09-02 5:28 ` David Miller
2018-09-05 22:55 ` Jason Gunthorpe
2018-09-10 15:16 ` Steve Wise
2018-09-11 15:19 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).