From mboxrd@z Thu Jan  1 00:00:00 1970
From: YueHaibing <yuehaibing@huawei.com>
Subject: Re: [PATCH net-next] net: caif: fix return type of ndo_start_xmit
 function
Date: Sun, 30 Sep 2018 09:52:55 +0800
Message-ID: <be1fc45d-3dca-3c41-a68a-e8d614bc4e6f@huawei.com>
References: <20180926092705.28880-1-yuehaibing@huawei.com>
 <20180929.113802.1016843680571572182.davem@davemloft.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Cc: <dmitry.tarnyagin@lockless.no>, <linux-kernel@vger.kernel.org>,
        <netdev@vger.kernel.org>
To: David Miller <davem@davemloft.net>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <20180929.113802.1016843680571572182.davem@davemloft.net>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: netdev.vger.kernel.org


On 2018/9/30 2:38, David Miller wrote:
> From: YueHaibing <yuehaibing@huawei.com>
> Date: Wed, 26 Sep 2018 17:27:05 +0800
> 
>> @@ -1014,7 +1014,7 @@ static int cfhsi_xmit(struct sk_buff *skb, struct net_device *dev)
>>  	int prio;
>>  
>>  	if (!dev)
>> -		return -EINVAL;
>> +		return NETDEV_TX_BUSY;
>>  
>>  	cfhsi = netdev_priv(dev);
>>  
> 
> Even though the return type of ndo_start_xmit is netdev_tx_t, negative error codes are
> still allowed I believe.

I missed this and do the wrong thing.

> 
> Look, reviewing these are pretty stressful for me, because you aren't documenting your
> changes and in many cases the transformations look incorrect.
> 

I'm really sorry for this.

> I'm tossing the rest of your changes in this area for now, sorry.
> 
> Please double check your work and resubmit this at some time in the not-too-near
> future.
> 
> Thank you.
> 
> .
>