From: Vadim Fedorenko <vadim.fedorenko@linux.dev>
To: Vladimir Oltean <vladimir.oltean@nxp.com>,
Horatiu Vultur <horatiu.vultur@microchip.com>
Cc: andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, richardcochran@gmail.com,
rmk+kernel@armlinux.org.uk, rosenp@gmail.com,
christophe.jaillet@wanadoo.fr, viro@zeniv.linux.org.uk,
quentin.schulz@bootlin.com, atenart@kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v4] phy: mscc: Fix timestamping for vsc8584
Date: Mon, 18 Aug 2025 14:53:22 +0100 [thread overview]
Message-ID: <be442867-109f-42fe-8af4-7e5ab4210662@linux.dev> (raw)
In-Reply-To: <20250818132141.ezxmflzzg6kj5t7k@skbuf>
On 18/08/2025 14:21, Vladimir Oltean wrote:
> On Mon, Aug 18, 2025 at 10:10:29AM +0200, Horatiu Vultur wrote:
>> diff --git a/drivers/net/phy/mscc/mscc_main.c b/drivers/net/phy/mscc/mscc_main.c
>> index 37e3e931a8e53..800da302ae632 100644
>> --- a/drivers/net/phy/mscc/mscc_main.c
>> +++ b/drivers/net/phy/mscc/mscc_main.c
>> @@ -2368,6 +2368,13 @@ static int vsc85xx_probe(struct phy_device *phydev)
>> return vsc85xx_dt_led_modes_get(phydev, default_mode);
>> }
>>
>> +static void vsc85xx_remove(struct phy_device *phydev)
>> +{
>> + struct vsc8531_private *priv = phydev->priv;
>> +
>> + skb_queue_purge(&priv->rx_skbs_list);
>> +}
>
> Have you tested this patch with an unbind/bind cycle? Haven't you found
> that a call to ptp_clock_unregister() is also missing?
It was missing before this patch as well, probably needs another patch
to fix this issue
next prev parent reply other threads:[~2025-08-18 13:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-18 8:10 [PATCH net v4] phy: mscc: Fix timestamping for vsc8584 Horatiu Vultur
2025-08-18 11:09 ` Vadim Fedorenko
2025-08-18 13:21 ` Vladimir Oltean
2025-08-18 13:53 ` Vadim Fedorenko [this message]
2025-08-18 14:01 ` Vladimir Oltean
2025-08-18 13:56 ` Horatiu Vultur
2025-08-18 14:13 ` Vladimir Oltean
2025-08-18 14:19 ` Horatiu Vultur
2025-08-18 14:37 ` Vladimir Oltean
2025-08-19 6:40 ` Horatiu Vultur
2025-08-19 8:25 ` Vladimir Oltean
2025-08-19 8:27 ` Vladimir Oltean
2025-08-20 3:11 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be442867-109f-42fe-8af4-7e5ab4210662@linux.dev \
--to=vadim.fedorenko@linux.dev \
--cc=andrew@lunn.ch \
--cc=atenart@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=horatiu.vultur@microchip.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quentin.schulz@bootlin.com \
--cc=richardcochran@gmail.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=rosenp@gmail.com \
--cc=viro@zeniv.linux.org.uk \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).