From: Paolo Abeni <pabeni@redhat.com>
To: Yunsheng Lin <linyunsheng@huawei.com>, Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Alexander Duyck <alexander.duyck@gmail.com>
Subject: Re: [PATCH net-next v20 14/14] mm: page_frag: add an entry in MAINTAINERS for page_frag
Date: Wed, 9 Oct 2024 18:32:34 +0200 [thread overview]
Message-ID: <be4be68a-caff-4657-9a49-67b3eaefe478@redhat.com> (raw)
In-Reply-To: <a3f94649-9880-4dc0-a8ab-d43fab7c9350@huawei.com>
Hi,
On 10/9/24 06:01, Yunsheng Lin wrote:
> On 2024/10/9 8:43, Jakub Kicinski wrote:
>> On Tue, 8 Oct 2024 19:20:48 +0800 Yunsheng Lin wrote:
>>> +M: Yunsheng Lin <linyunsheng@huawei.com>
>>
>> The bar for maintaining core code is very high, if you'd
>> like to be a maintainer please start small.
>
> I did start small with the page_pool case, as mentioned in
> [1] of a similar comment, and the page_frag is a small
> subsystem/library as mentioned in commit log.
>
> I think I still might need a second opinion here.
>
> 1. https://lore.kernel.org/linux-kernel/dea82ac3-65fc-c941-685f-9d4655aa4a52@huawei.com/
Please note that the 'small' part here does not refer strictly to code
size. Any core networking code has the bar significantly higher than
i.e. NIC drivers - even if the latter could count order of magnitude
more LoC.
AFAICS there is an unwritten convention that people are called to
maintain core code, as opposed to people appointing themself to maintain
driver code.
Cheers,
Paolo
next prev parent reply other threads:[~2024-10-09 16:32 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-08 11:20 [PATCH net-next v20 00/14] Replace page_frag with page_frag_cache for sk_page_frag() Yunsheng Lin
2024-10-08 11:20 ` [PATCH net-next v20 01/14] mm: page_frag: add a test module for page_frag Yunsheng Lin
2024-10-08 19:56 ` Shuah Khan
2024-10-09 3:59 ` Yunsheng Lin
2024-10-10 21:18 ` Shuah Khan
2024-10-08 11:20 ` [PATCH net-next v20 02/14] mm: move the page fragment allocator from page_alloc into its own file Yunsheng Lin
2024-10-08 11:20 ` [PATCH net-next v20 03/14] mm: page_frag: use initial zero offset for page_frag_alloc_align() Yunsheng Lin
2024-10-08 11:20 ` [PATCH net-next v20 04/14] mm: page_frag: avoid caller accessing 'page_frag_cache' directly Yunsheng Lin
2024-10-08 11:20 ` [PATCH net-next v20 05/14] xtensa: remove the get_order() implementation Yunsheng Lin
2024-10-08 11:20 ` [PATCH net-next v20 06/14] mm: page_frag: reuse existing space for 'size' and 'pfmemalloc' Yunsheng Lin
2024-10-09 23:50 ` Alexander Duyck
2024-10-10 11:32 ` Yunsheng Lin
2024-10-10 14:33 ` Alexander Duyck
2024-10-11 11:40 ` Yunsheng Lin
2024-10-11 15:31 ` Alexander Duyck
2024-10-08 11:20 ` [PATCH net-next v20 07/14] mm: page_frag: some minor refactoring before adding new API Yunsheng Lin
2024-10-08 11:20 ` [PATCH net-next v20 08/14] mm: page_frag: use __alloc_pages() to replace alloc_pages_node() Yunsheng Lin
2024-10-08 11:20 ` [PATCH net-next v20 09/14] net: rename skb_copy_to_page_nocache() helper Yunsheng Lin
2024-10-09 23:40 ` Alexander Duyck
2024-10-10 11:32 ` Yunsheng Lin
2024-10-10 14:39 ` Alexander Duyck
2024-10-08 11:20 ` [PATCH net-next v20 10/14] mm: page_frag: introduce prepare/probe/commit API Yunsheng Lin
2024-10-08 11:20 ` [PATCH net-next v20 11/14] mm: page_frag: add testing for the newly added prepare API Yunsheng Lin
2024-10-08 11:20 ` [PATCH net-next v20 12/14] net: replace page_frag with page_frag_cache Yunsheng Lin
2024-10-08 11:20 ` [PATCH net-next v20 13/14] mm: page_frag: update documentation for page_frag Yunsheng Lin
2024-10-08 11:20 ` [PATCH net-next v20 14/14] mm: page_frag: add an entry in MAINTAINERS " Yunsheng Lin
2024-10-09 0:43 ` Jakub Kicinski
2024-10-09 4:01 ` Yunsheng Lin
2024-10-09 16:32 ` Paolo Abeni [this message]
2024-10-10 11:37 ` Yunsheng Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be4be68a-caff-4657-9a49-67b3eaefe478@redhat.com \
--to=pabeni@redhat.com \
--cc=alexander.duyck@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linyunsheng@huawei.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).