* [PATCH net-next] r8169: silence sparse warning in rtl8169_start_xmit
@ 2019-06-06 5:49 Heiner Kallweit
2019-06-06 17:24 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Heiner Kallweit @ 2019-06-06 5:49 UTC (permalink / raw)
To: Realtek linux nic maintainers, David Miller; +Cc: netdev@vger.kernel.org
The opts[] array is of type u32. Therefore remove the wrong
cpu_to_le32(). The opts[] array members are converted to little endian
later when being assigned to the respective descriptor fields.
This is not a new issue, it just popped up due to r8169.c having
been renamed and more thoroughly checked. Due to the renaming
this patch applies to net-next only.
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/net/ethernet/realtek/r8169_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
index d34cc855f..8b7d45ff1 100644
--- a/drivers/net/ethernet/realtek/r8169_main.c
+++ b/drivers/net/ethernet/realtek/r8169_main.c
@@ -5621,7 +5621,7 @@ static netdev_tx_t rtl8169_start_xmit(struct sk_buff *skb,
if (unlikely(le32_to_cpu(txd->opts1) & DescOwn))
goto err_stop_0;
- opts[1] = cpu_to_le32(rtl8169_tx_vlan_tag(skb));
+ opts[1] = rtl8169_tx_vlan_tag(skb);
opts[0] = DescOwn;
if (rtl_chip_supports_csum_v2(tp)) {
--
2.21.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net-next] r8169: silence sparse warning in rtl8169_start_xmit
2019-06-06 5:49 [PATCH net-next] r8169: silence sparse warning in rtl8169_start_xmit Heiner Kallweit
@ 2019-06-06 17:24 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-06-06 17:24 UTC (permalink / raw)
To: hkallweit1; +Cc: nic_swsd, netdev
From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Thu, 6 Jun 2019 07:49:17 +0200
> The opts[] array is of type u32. Therefore remove the wrong
> cpu_to_le32(). The opts[] array members are converted to little endian
> later when being assigned to the respective descriptor fields.
>
> This is not a new issue, it just popped up due to r8169.c having
> been renamed and more thoroughly checked. Due to the renaming
> this patch applies to net-next only.
>
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-06 17:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-06 5:49 [PATCH net-next] r8169: silence sparse warning in rtl8169_start_xmit Heiner Kallweit
2019-06-06 17:24 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).