* [PATCH net] tcp: Export tcp_write_queue_purge()
@ 2020-07-30 21:07 Florian Fainelli
2020-07-30 21:16 ` Eric Dumazet
0 siblings, 1 reply; 6+ messages in thread
From: Florian Fainelli @ 2020-07-30 21:07 UTC (permalink / raw)
To: netdev
Cc: Florian Fainelli, Eric Dumazet, David S. Miller, Alexey Kuznetsov,
Hideaki YOSHIFUJI, Jakub Kicinski, open list
After tcp_write_queue_purge() got uninlined with commit ac3f09ba3e49
("tcp: uninline tcp_write_queue_purge()"), it became no longer possible
to reference this symbol from kernel modules.
Fixes: ac3f09ba3e49 ("tcp: uninline tcp_write_queue_purge()")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
net/ipv4/tcp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
index 6f0caf9a866d..ea9d296a8380 100644
--- a/net/ipv4/tcp.c
+++ b/net/ipv4/tcp.c
@@ -2626,6 +2626,7 @@ void tcp_write_queue_purge(struct sock *sk)
tcp_sk(sk)->packets_out = 0;
inet_csk(sk)->icsk_backoff = 0;
}
+EXPORT_SYMBOL(tcp_write_queue_purge);
int tcp_disconnect(struct sock *sk, int flags)
{
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH net] tcp: Export tcp_write_queue_purge()
2020-07-30 21:07 [PATCH net] tcp: Export tcp_write_queue_purge() Florian Fainelli
@ 2020-07-30 21:16 ` Eric Dumazet
2020-07-30 21:23 ` Florian Fainelli
0 siblings, 1 reply; 6+ messages in thread
From: Eric Dumazet @ 2020-07-30 21:16 UTC (permalink / raw)
To: Florian Fainelli
Cc: netdev, David S. Miller, Alexey Kuznetsov, Hideaki YOSHIFUJI,
Jakub Kicinski, open list
On Thu, Jul 30, 2020 at 2:07 PM Florian Fainelli <f.fainelli@gmail.com> wrote:
>
> After tcp_write_queue_purge() got uninlined with commit ac3f09ba3e49
> ("tcp: uninline tcp_write_queue_purge()"), it became no longer possible
> to reference this symbol from kernel modules.
>
> Fixes: ac3f09ba3e49 ("tcp: uninline tcp_write_queue_purge()")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> net/ipv4/tcp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
> index 6f0caf9a866d..ea9d296a8380 100644
> --- a/net/ipv4/tcp.c
> +++ b/net/ipv4/tcp.c
> @@ -2626,6 +2626,7 @@ void tcp_write_queue_purge(struct sock *sk)
> tcp_sk(sk)->packets_out = 0;
> inet_csk(sk)->icsk_backoff = 0;
> }
> +EXPORT_SYMBOL(tcp_write_queue_purge);
>
> int tcp_disconnect(struct sock *sk, int flags)
> {
> --
> 2.17.1
>
Hmmm.... which module would need this exactly ?
How come it took 3 years to discover this issue ?
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH net] tcp: Export tcp_write_queue_purge()
2020-07-30 21:16 ` Eric Dumazet
@ 2020-07-30 21:23 ` Florian Fainelli
2020-07-30 21:32 ` David Miller
2020-07-30 21:32 ` Eric Dumazet
0 siblings, 2 replies; 6+ messages in thread
From: Florian Fainelli @ 2020-07-30 21:23 UTC (permalink / raw)
To: Eric Dumazet
Cc: netdev, David S. Miller, Alexey Kuznetsov, Hideaki YOSHIFUJI,
Jakub Kicinski, open list
On 7/30/20 2:16 PM, Eric Dumazet wrote:
> On Thu, Jul 30, 2020 at 2:07 PM Florian Fainelli <f.fainelli@gmail.com> wrote:
>>
>> After tcp_write_queue_purge() got uninlined with commit ac3f09ba3e49
>> ("tcp: uninline tcp_write_queue_purge()"), it became no longer possible
>> to reference this symbol from kernel modules.
>>
>> Fixes: ac3f09ba3e49 ("tcp: uninline tcp_write_queue_purge()")
>> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
>> ---
>> net/ipv4/tcp.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
>> index 6f0caf9a866d..ea9d296a8380 100644
>> --- a/net/ipv4/tcp.c
>> +++ b/net/ipv4/tcp.c
>> @@ -2626,6 +2626,7 @@ void tcp_write_queue_purge(struct sock *sk)
>> tcp_sk(sk)->packets_out = 0;
>> inet_csk(sk)->icsk_backoff = 0;
>> }
>> +EXPORT_SYMBOL(tcp_write_queue_purge);
>>
>> int tcp_disconnect(struct sock *sk, int flags)
>> {
>> --
>> 2.17.1
>>
>
> Hmmm.... which module would need this exactly ?
None in tree unfortunately, and I doubt it would be published one day.
For consistency one could argue that given it used to be accessible, and
other symbols within net/ipv4/tcp.c are also exported, so this should
one be. Not going to hold that line of argumentation more than in this
email, if you object to it, that would be completely fine with me.
>
> How come it took 3 years to discover this issue ?
We just upgraded our downstream kernel from 4.9 to 5.4 and this is why
it took so long.
--
Florian
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH net] tcp: Export tcp_write_queue_purge()
2020-07-30 21:23 ` Florian Fainelli
@ 2020-07-30 21:32 ` David Miller
2020-07-30 21:32 ` Eric Dumazet
1 sibling, 0 replies; 6+ messages in thread
From: David Miller @ 2020-07-30 21:32 UTC (permalink / raw)
To: f.fainelli; +Cc: edumazet, netdev, kuznet, yoshfuji, kuba, linux-kernel
From: Florian Fainelli <f.fainelli@gmail.com>
Date: Thu, 30 Jul 2020 14:23:50 -0700
> On 7/30/20 2:16 PM, Eric Dumazet wrote:
>> On Thu, Jul 30, 2020 at 2:07 PM Florian Fainelli <f.fainelli@gmail.com> wrote:
>> Hmmm.... which module would need this exactly ?
>
> None in tree unfortunately, and I doubt it would be published one day.
> For consistency one could argue that given it used to be accessible, and
> other symbols within net/ipv4/tcp.c are also exported, so this should
> one be. Not going to hold that line of argumentation more than in this
> email, if you object to it, that would be completely fine with me.
>
>>
>> How come it took 3 years to discover this issue ?
>
> We just upgraded our downstream kernel from 4.9 to 5.4 and this is why
> it took so long.
We really can't do this, sorry.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net] tcp: Export tcp_write_queue_purge()
2020-07-30 21:23 ` Florian Fainelli
2020-07-30 21:32 ` David Miller
@ 2020-07-30 21:32 ` Eric Dumazet
2020-07-30 22:03 ` Florian Fainelli
1 sibling, 1 reply; 6+ messages in thread
From: Eric Dumazet @ 2020-07-30 21:32 UTC (permalink / raw)
To: Florian Fainelli
Cc: netdev, David S. Miller, Alexey Kuznetsov, Hideaki YOSHIFUJI,
Jakub Kicinski, open list
On Thu, Jul 30, 2020 at 2:24 PM Florian Fainelli <f.fainelli@gmail.com> wrote:
>
> On 7/30/20 2:16 PM, Eric Dumazet wrote:
> > On Thu, Jul 30, 2020 at 2:07 PM Florian Fainelli <f.fainelli@gmail.com> wrote:
> >>
> >> After tcp_write_queue_purge() got uninlined with commit ac3f09ba3e49
> >> ("tcp: uninline tcp_write_queue_purge()"), it became no longer possible
> >> to reference this symbol from kernel modules.
> >>
> >> Fixes: ac3f09ba3e49 ("tcp: uninline tcp_write_queue_purge()")
> >> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> >> ---
> >> net/ipv4/tcp.c | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
> >> index 6f0caf9a866d..ea9d296a8380 100644
> >> --- a/net/ipv4/tcp.c
> >> +++ b/net/ipv4/tcp.c
> >> @@ -2626,6 +2626,7 @@ void tcp_write_queue_purge(struct sock *sk)
> >> tcp_sk(sk)->packets_out = 0;
> >> inet_csk(sk)->icsk_backoff = 0;
> >> }
> >> +EXPORT_SYMBOL(tcp_write_queue_purge);
> >>
> >> int tcp_disconnect(struct sock *sk, int flags)
> >> {
> >> --
> >> 2.17.1
> >>
> >
> > Hmmm.... which module would need this exactly ?
>
> None in tree unfortunately, and I doubt it would be published one day.
> For consistency one could argue that given it used to be accessible, and
> other symbols within net/ipv4/tcp.c are also exported, so this should
> one be. Not going to hold that line of argumentation more than in this
> email, if you object to it, that would be completely fine with me.
:)
>
> >
> > How come it took 3 years to discover this issue ?
>
> We just upgraded our downstream kernel from 4.9 to 5.4 and this is why
> it took so long.
It is not because TCP used an inline function in the past that it
means we have to keep
the equivalent function available for all possible out-of-tree modules.
Sorry, we can not accept that out-of-tree modules use TCP stack like that.
You will have to carry this change locally. Or even better get rid of it.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH net] tcp: Export tcp_write_queue_purge()
2020-07-30 21:32 ` Eric Dumazet
@ 2020-07-30 22:03 ` Florian Fainelli
0 siblings, 0 replies; 6+ messages in thread
From: Florian Fainelli @ 2020-07-30 22:03 UTC (permalink / raw)
To: Eric Dumazet
Cc: netdev, David S. Miller, Alexey Kuznetsov, Hideaki YOSHIFUJI,
Jakub Kicinski, open list
On 7/30/20 2:32 PM, Eric Dumazet wrote:
> On Thu, Jul 30, 2020 at 2:24 PM Florian Fainelli <f.fainelli@gmail.com> wrote:
>>
>> On 7/30/20 2:16 PM, Eric Dumazet wrote:
>>> On Thu, Jul 30, 2020 at 2:07 PM Florian Fainelli <f.fainelli@gmail.com> wrote:
>>>>
>>>> After tcp_write_queue_purge() got uninlined with commit ac3f09ba3e49
>>>> ("tcp: uninline tcp_write_queue_purge()"), it became no longer possible
>>>> to reference this symbol from kernel modules.
>>>>
>>>> Fixes: ac3f09ba3e49 ("tcp: uninline tcp_write_queue_purge()")
>>>> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
>>>> ---
>>>> net/ipv4/tcp.c | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
>>>> index 6f0caf9a866d..ea9d296a8380 100644
>>>> --- a/net/ipv4/tcp.c
>>>> +++ b/net/ipv4/tcp.c
>>>> @@ -2626,6 +2626,7 @@ void tcp_write_queue_purge(struct sock *sk)
>>>> tcp_sk(sk)->packets_out = 0;
>>>> inet_csk(sk)->icsk_backoff = 0;
>>>> }
>>>> +EXPORT_SYMBOL(tcp_write_queue_purge);
>>>>
>>>> int tcp_disconnect(struct sock *sk, int flags)
>>>> {
>>>> --
>>>> 2.17.1
>>>>
>>>
>>> Hmmm.... which module would need this exactly ?
>>
>> None in tree unfortunately, and I doubt it would be published one day.
>> For consistency one could argue that given it used to be accessible, and
>> other symbols within net/ipv4/tcp.c are also exported, so this should
>> one be. Not going to hold that line of argumentation more than in this
>> email, if you object to it, that would be completely fine with me.
>
> :)
>
>>
>>>
>>> How come it took 3 years to discover this issue ?
>>
>> We just upgraded our downstream kernel from 4.9 to 5.4 and this is why
>> it took so long.
>
> It is not because TCP used an inline function in the past that it
> means we have to keep
> the equivalent function available for all possible out-of-tree modules.
>
> Sorry, we can not accept that out-of-tree modules use TCP stack like that.
>
> You will have to carry this change locally. Or even better get rid of it.
Sure, that is completely fair, I had to try though :)
--
Florian
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-07-30 22:03 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-30 21:07 [PATCH net] tcp: Export tcp_write_queue_purge() Florian Fainelli
2020-07-30 21:16 ` Eric Dumazet
2020-07-30 21:23 ` Florian Fainelli
2020-07-30 21:32 ` David Miller
2020-07-30 21:32 ` Eric Dumazet
2020-07-30 22:03 ` Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).