From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8483CC43381 for ; Sun, 24 Mar 2019 01:01:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 43E3B217D8 for ; Sun, 24 Mar 2019 01:01:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JZ2/rC3/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727904AbfCXBBU (ORCPT ); Sat, 23 Mar 2019 21:01:20 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:40371 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727625AbfCXBBT (ORCPT ); Sat, 23 Mar 2019 21:01:19 -0400 Received: by mail-pg1-f196.google.com with SMTP id u9so3980089pgo.7 for ; Sat, 23 Mar 2019 18:01:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=aEUpoNCGTn4CXBB8o76xyTh8nV4I09ScscvKW+urJ8k=; b=JZ2/rC3/ZxgU3FwSXr5eEcAPRLARAgsg/kmd+9CeOTjzMxtwUYtMEWj0M/gi0//t5O loUkrm1CBgsfAo+oXUwnZ7yZCkOFVH04IaTCE4nkE9vN5EkJTM48fVxf/PaLsd15wIF2 AOhY7z4XooPx6evIwfupNPKQpxXMLZLEQfyyTL5aKlwpx4yYLe117mFN5OfP8MxM96ri xJuEYRryXjX9DOvDsLqz4D+4M6QvIHzp4z2IJ5yDV390YVXFeXMZljDievr9rhJo1D/u kiMW6lBHa00luHv6lQYFCCb6dv4irhn1PZh0UCDGU4IRzAB4Z0UVN9LlQzbCA0trKAxZ y9OQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=aEUpoNCGTn4CXBB8o76xyTh8nV4I09ScscvKW+urJ8k=; b=EHipS8hRqfqwq8Ebtzjmq7+5Kx1zQ/EXrXdXehz6eb2biqxj5KTa2dOX4d15QRnR7D jyHj01pnE6Hcyq1kvKn+fKhsfevygw05e8lR3KhfqLDEufrfe4l4w0QEtyZ5vi7WlPtF cFS1PHBve7HakkUAS0p6yqdMKnnG14xvmR1lribEpB1jGoXkNNKYmIkknA5fPob22ePO Sq1jw1e/iLrFBmscgguWTlzX6zD/IRwRaJfM6ntzJcdcpPKOaz3lV/0acliQgkjHymeA KLrjA7X/CJZJrSSE+bs8nzeDmCZES0y5bYwXVetbQ8Wy1fmJLdaaOa+CMA/xGESGWfXP iq9A== X-Gm-Message-State: APjAAAWV0HvrvaDWCEGV3bAvifU5CdwRzoFsMsMBbE1Iv16OA+dmdc53 itvwDXRfZSlOZgPU+XISRrhbyvRi X-Google-Smtp-Source: APXvYqxBYxHhnBioSTPiIvz4rLsE80yN4P5eWBeAESYKc8WidXwS6x1fGEJhOWWi5mzd8V/qgiMAAg== X-Received: by 2002:a63:5a20:: with SMTP id o32mr15656976pgb.225.1553389278770; Sat, 23 Mar 2019 18:01:18 -0700 (PDT) Received: from [192.168.1.3] (ip68-101-123-102.oc.oc.cox.net. [68.101.123.102]) by smtp.gmail.com with ESMTPSA id k10sm19708159pgj.11.2019.03.23.18.01.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 23 Mar 2019 18:01:18 -0700 (PDT) Subject: Re: [PATCH net-next 1/3] net: phy: aquantia: report remote capabilities if link partner is Aquantia PHY To: Heiner Kallweit , Andrew Lunn , David Miller Cc: "netdev@vger.kernel.org" References: <0e35a866-e3a5-6d49-2353-008f14ed6ff4@gmail.com> <265860ca-a5d0-e0f6-3caa-a300b35d2ded@gmail.com> From: Florian Fainelli Openpgp: preference=signencrypt Message-ID: Date: Sat, 23 Mar 2019 18:01:15 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.0 MIME-Version: 1.0 In-Reply-To: <265860ca-a5d0-e0f6-3caa-a300b35d2ded@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 3/23/2019 6:14 AM, Heiner Kallweit wrote: > If both link partners are Aquantia PHY's then additional information is > exchanged as part of the auto-negotiation. Report remote capabilities > if link partner is Aquantia PHY. > > Signed-off-by: Heiner Kallweit Reviewed-by: Florian Fainelli Petr is trying to introduce a link down reason, but it sounds like we should also have have a way to enhance the link up with information like the one you are providing here. It would also be nice if in the future, ethtool could display additional vendor specific information when the link is up. ethtool over netlink should facilitate that. Thanks! -- Florian