From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 866A0C433E0 for ; Thu, 4 Feb 2021 02:10:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4035064F4E for ; Thu, 4 Feb 2021 02:10:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233057AbhBDCKr (ORCPT ); Wed, 3 Feb 2021 21:10:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231550AbhBDCKo (ORCPT ); Wed, 3 Feb 2021 21:10:44 -0500 Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8AD4CC0613D6; Wed, 3 Feb 2021 18:10:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:To:Subject:Sender: Reply-To:Cc:Content-ID:Content-Description; bh=qpZXbW6EJfxgDufWrNMMYF+eNpvsq+lvzqFizGqVhaw=; b=LYnWJpaHdQRlqryZJtk5hjlnWM zebhtvBAVeIQ/8eqLc7/AgEYRe/OW12kGVqAjqPnaPvYBbY99KKGOAhcrLG4PFgUwFg3R7ZhaHgIB CRw00VCXz9AYn3+bZMnlnMcojekI3kT2k+85AWColBGffhddK8cq4GASCSTcD1NcrE3j84+oGgH4+ ZjxaZO5RYQ8Q0967lwEi2FCUu7DbbN1vygKurEmLt0pVvk9jlEIGZitonB1XhBHdKzIv/EHdflL8I K6LMwuEGls8qgsyaY0UWKoo2tKKs12eFlfq1UHURpT1xH+GniYBzH3Qcdh2urbpRxJAp5VFVG1nqg FVO2lRrw==; Received: from [2601:1c0:6280:3f0::aec2] by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7U5p-0002nc-Ap; Thu, 04 Feb 2021 02:10:01 +0000 Subject: Re: [PATCH V2] drivers: net: ethernet: i825xx: Fix couple of spellings and get rid of blank lines too in the file ether1.c To: Bhaskar Chowdhury , linux@armlinux.org.uk, davem@davemloft.net, kuba@kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210204011821.18356-1-unixbhaskar@gmail.com> From: Randy Dunlap Message-ID: Date: Wed, 3 Feb 2021 18:09:54 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20210204011821.18356-1-unixbhaskar@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2/3/21 5:18 PM, Bhaskar Chowdhury wrote: > > s/initialsation/initialisation/ > s/specifiing/specifying/ > > Plus get rid of few blank lines. > > Signed-off-by: Bhaskar Chowdhury > --- > Changes from V1: > Fix typo in the subject line > Give explanation of all the changes in changelog text > > drivers/net/ethernet/i825xx/ether1.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/drivers/net/ethernet/i825xx/ether1.c b/drivers/net/ethernet/i825xx/ether1.c > index a0bfb509e002..850ea32091ed 100644 > --- a/drivers/net/ethernet/i825xx/ether1.c > +++ b/drivers/net/ethernet/i825xx/ether1.c a. don't delete the blank lines b. the change below is not described and does not change any whitespace AFAICT. I.e., DDT [don't do that]. > @@ -1047,7 +1044,7 @@ static void ether1_remove(struct expansion_card *ec) > { > struct net_device *dev = ecard_get_drvdata(ec); > > - ecard_set_drvdata(ec, NULL); > + ecard_set_drvdata(ec, NULL); > > unregister_netdev(dev); > free_netdev(dev); -- ~Randy