From: David Laight <David.Laight@ACULAB.COM>
To: 'Cambda Zhu' <cambda@linux.alibaba.com>, netdev <netdev@vger.kernel.org>
Cc: Dust Li <dust.li@linux.alibaba.com>, Tony Lu <tonylu@linux.alibaba.com>
Subject: RE: [PATCH net-next] net: Add TCP_FORCE_LINGER2 to TCP setsockopt
Date: Thu, 23 Apr 2020 08:52:35 +0000 [thread overview]
Message-ID: <beaecc68abcc4b268d68ce558fc5766e@AcuMS.aculab.com> (raw)
In-Reply-To: <20200421121737.3269-1-cambda@linux.alibaba.com>
From: Cambda Zhu
> Sent: 21 April 2020 13:18
>
> This patch adds a new TCP socket option named TCP_FORCE_LINGER2. The
> option has same behavior as TCP_LINGER2, except the tp->linger2 value
> can be greater than sysctl_tcp_fin_timeout if the user_ns is capable
> with CAP_NET_ADMIN.
Did you consider adding an extra sysctl so that the limit
for TCP_LINGER2 could be greater than the default?
It might even be sensible to set the limit to a few times
the default.
All users can set the socket buffer sizes to twice the default.
Being able to do the same for the linger timeout wouldn't be a problem.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2020-04-23 8:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 12:17 [PATCH net-next] net: Add TCP_FORCE_LINGER2 to TCP setsockopt Cambda Zhu
2020-04-23 2:19 ` David Miller
2020-04-23 3:01 ` Eric Dumazet
2020-04-23 7:35 ` [PATCH net-next v2] " Cambda Zhu
2020-04-23 13:40 ` Eric Dumazet
2020-04-23 14:46 ` Cambda Zhu
2020-04-23 16:59 ` Eric Dumazet
2020-04-24 2:56 ` Cambda Zhu
2020-04-24 4:23 ` Eric Dumazet
2020-04-23 13:43 ` Willem de Bruijn
2020-04-23 15:02 ` Cambda Zhu
2020-04-24 8:06 ` [PATCH net-next v3] net: Replace the limit of TCP_LINGER2 with TCP_FIN_TIMEOUT_MAX Cambda Zhu
2020-05-01 22:12 ` David Miller
2020-04-23 8:52 ` David Laight [this message]
2020-04-23 10:33 ` [PATCH net-next] net: Add TCP_FORCE_LINGER2 to TCP setsockopt Cambda Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=beaecc68abcc4b268d68ce558fc5766e@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=cambda@linux.alibaba.com \
--cc=dust.li@linux.alibaba.com \
--cc=netdev@vger.kernel.org \
--cc=tonylu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).