From mboxrd@z Thu Jan  1 00:00:00 1970
From: Neil Armstrong <narmstrong@baylibre.com>
Subject: Re: [PATCH net-next v3 1/2] net: stmmac: Rework coalesce timer and
 fix multi-queue races
Date: Thu, 13 Sep 2018 13:24:48 +0200
Message-ID: <bede6803-6acc-d511-3ab8-05f039ad0d59@baylibre.com>
References: <cover.1536762575.git.joabreu@synopsys.com>
 <b7da85496a6f536decb54bc9cc8f9a77d3fef978.1536762575.git.joabreu@synopsys.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: Florian Fainelli <f.fainelli@gmail.com>,
        Jerome Brunet <jbrunet@baylibre.com>,
        Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Joao Pinto <Joao.Pinto@synopsys.com>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@st.com>
To: Jose Abreu <Jose.Abreu@synopsys.com>, netdev@vger.kernel.org
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-wr1-f66.google.com ([209.85.221.66]:47036 "EHLO
        mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726828AbeIMQdy (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 13 Sep 2018 12:33:54 -0400
Received: by mail-wr1-f66.google.com with SMTP id a108-v6so5200921wrc.13
        for <netdev@vger.kernel.org>; Thu, 13 Sep 2018 04:24:51 -0700 (PDT)
In-Reply-To: <b7da85496a6f536decb54bc9cc8f9a77d3fef978.1536762575.git.joabreu@synopsys.com>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Hi Jose,

On 13/09/2018 10:02, Jose Abreu wrote:
> This follows David Miller advice and tries to fix coalesce timer in
> multi-queue scenarios.
> 
> We are now using per-queue coalesce values and per-queue TX timer.
> 
> Coalesce timer default values was changed to 1ms and the coalesce frames
> to 25.
> 
> Tested in B2B setup between XGMAC2 and GMAC5.

I will run a test today,

Thanks,
Neil

> 
> Signed-off-by: Jose Abreu <joabreu@synopsys.com>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Cc: Neil Armstrong <narmstrong@baylibre.com>
> Cc: Jerome Brunet <jbrunet@baylibre.com>
> Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> Cc: David S. Miller <davem@davemloft.net>
> Cc: Joao Pinto <jpinto@synopsys.com>
> Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
> Cc: Alexandre Torgue <alexandre.torgue@st.com>
> ---
>  drivers/net/ethernet/stmicro/stmmac/common.h      |   4 +-
>  drivers/net/ethernet/stmicro/stmmac/stmmac.h      |  14 +-
>  drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 233 ++++++++++++----------
>  include/linux/stmmac.h                            |   1 +
>  4 files changed, 146 insertions(+), 106 deletions(-)

[...]