From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH net 0/4] net: dsa: Use strncpy() for ethtool::get_strings Date: Thu, 1 Mar 2018 20:34:12 -0800 Message-ID: References: <20180302002529.15226-1-f.fainelli@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: Andrew Lunn , Vivien Didelot , Woojung Huh , Microchip Linux Driver Support , open list To: netdev@vger.kernel.org, "David S. Miller" Return-path: In-Reply-To: <20180302002529.15226-1-f.fainelli@gmail.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Hi David, On 03/01/2018 04:25 PM, Florian Fainelli wrote: > Hi all, > > After turning on KASAN on one of my systems, I started getting lots of out of > bounds errors while fetching a given port's statistics, and indeed using > memcpy() is unsafe for copying strings, so let's use strncpy() instead. Looks like only patch 1 is necessary, but there are more drivers with the same pattern under drivers/net/phy: marvell.c, micrel.c and bcm-phy-lib.c, so I will submit a v2 with those fixed. > > Florian Fainelli (4): > net: dsa: b53: Use strncpy() for ethtool::get_strings > net: dsa: loop: Use strncpy() for ethtool::get_strings > net: dsa: microchip: Utilize strncpy() for ethtool::get_strings > net: dsa: mv88e6xxx: Utilize strncpy() for ethtool::get_strings > > drivers/net/dsa/b53/b53_common.c | 4 ++-- > drivers/net/dsa/dsa_loop.c | 4 ++-- > drivers/net/dsa/microchip/ksz_common.c | 4 ++-- > drivers/net/dsa/mv88e6xxx/chip.c | 4 ++-- > 4 files changed, 8 insertions(+), 8 deletions(-) > -- Florian