From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Borkmann <daniel@iogearbox.net>
Subject: Re: [PATCH bpf-next v2] tools/bpf: bpftool: improve output format for
 bpftool net
Date: Tue, 18 Sep 2018 17:48:23 +0200
Message-ID: <befbadbb-5e2c-04e9-7a48-0e97095fab60@iogearbox.net>
References: <20180917231300.1188382-1-yhs@fb.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: kernel-team@fb.com
To: Yonghong Song <yhs@fb.com>, ast@fb.com, netdev@vger.kernel.org
Return-path: <netdev-owner@vger.kernel.org>
Received: from www62.your-server.de ([213.133.104.62]:41684 "EHLO
        www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1728912AbeIRVVg (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 18 Sep 2018 17:21:36 -0400
In-Reply-To: <20180917231300.1188382-1-yhs@fb.com>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 09/18/2018 01:13 AM, Yonghong Song wrote:
> This is a followup patch for Commit f6f3bac08ff9
> ("tools/bpf: bpftool: add net support").
> Some improvements are made for the bpftool net output.
> Specially, plain output is more concise such that
> per attachment should nicely fit in one line.
> Compared to previous output, the prog tag is removed
> since it can be easily obtained with program id.
> Similar to xdp attachments, the device name is added
> to tc attachments.
> 
> The bpf program attached through shared block
> mechanism is supported as well.
>   $ ip link add dev v1 type veth peer name v2
>   $ tc qdisc add dev v1 ingress_block 10 egress_block 20 clsact
>   $ tc qdisc add dev v2 ingress_block 10 egress_block 20 clsact
>   $ tc filter add block 10 protocol ip prio 25 bpf obj bpf_shared.o sec ingress flowid 1:1
>   $ tc filter add block 20 protocol ip prio 30 bpf obj bpf_cyclic.o sec classifier flowid 1:1
>   $ bpftool net
>   xdp:
> 
>   tc:
>   v2(7) clsact/ingress bpf_shared.o:[ingress] id 23
>   v2(7) clsact/egress bpf_cyclic.o:[classifier] id 24
>   v1(8) clsact/ingress bpf_shared.o:[ingress] id 23
>   v1(8) clsact/egress bpf_cyclic.o:[classifier] id 24
> 
> The documentation and "bpftool net help" are updated
> to make it clear that current implementation only
> supports xdp and tc attachments. For programs
> attached to cgroups, "bpftool cgroup" can be used
> to dump attachments. For other programs e.g.
> sk_{filter,skb,msg,reuseport} and lwt/seg6,
> iproute2 tools should be used.
> 
> The new output:
>   $ bpftool net
>   xdp:
>   eth0(2) driver id 198
> 
>   tc:
>   eth0(2) clsact/ingress fbflow_icmp id 335 act [{icmp_action id 336}]
>   eth0(2) clsact/egress fbflow_egress id 334
>   $ bpftool -jp net
>   [{
>         "xdp": [{
>                 "devname": "eth0",
>                 "ifindex": 2,
>                 "mode": "driver",
>                 "id": 198
>             }
>         ],
>         "tc": [{
>                 "devname": "eth0",
>                 "ifindex": 2,
>                 "kind": "clsact/ingress",
>                 "name": "fbflow_icmp",
>                 "id": 335,
>                 "act": [{
>                         "name": "icmp_action",
>                         "id": 336
>                     }
>                 ]
>             },{
>                 "devname": "eth0",
>                 "ifindex": 2,
>                 "kind": "clsact/egress",
>                 "name": "fbflow_egress",
>                 "id": 334
>             }
>         ]
>     }
>   ]
> 
> Signed-off-by: Yonghong Song <yhs@fb.com>

Applied to bpf-next, thanks!