From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f54.google.com (mail-oa1-f54.google.com [209.85.160.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B209328B71 for ; Tue, 28 Apr 2026 16:47:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777394853; cv=none; b=Q5cyfxtHrCY9X5EgEc+mfpSlUZqfXR3CyBNA/cd4Ns17sX65zzpChe4nfX6jyh3VbwAzpTFFK5pGEJqKs/oTFQlrRmmF2zptU53GL2ODhB7Rc0NdlIxS0+UGr1sksC1cPo12k/5cI3fRdQg2t6CQj/bhsKS75GO3MV1P9lhl8mg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777394853; c=relaxed/simple; bh=9S9GoA2wdMOKBwQUq6uU4RsjDD9B9w9gbFBChUNcp5Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BJnZlt9NOyXffvP78fRQ38ezUiTU1azCqEY7d9Y6a0YW+qZBUgSel//Vh96QQ5tlxS79q+0tKHpk34Ttgkmh1wE9+gxLzt59ge8V1D6c3Ql57kZrFZw9LgL+h0wu3c2ZO6pZF83GHKjBgJjK0R26KLVwOPHWZrIBmJVWHp39WQk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=ieee.org; spf=pass smtp.mailfrom=ieee.org; dkim=pass (1024-bit key) header.d=ieee.org header.i=@ieee.org header.b=XfiIGnuM; arc=none smtp.client-ip=209.85.160.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=ieee.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ieee.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ieee.org header.i=@ieee.org header.b="XfiIGnuM" Received: by mail-oa1-f54.google.com with SMTP id 586e51a60fabf-4042fe53946so5208367fac.3 for ; Tue, 28 Apr 2026 09:47:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ieee.org; s=google; t=1777394849; x=1777999649; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=lsaS50fJFWEgKS/X3mmwXYg/L5d5/h6qIX6nFemmP8U=; b=XfiIGnuMwfnSZxVU2xMgiQkpcZx9aOzJFtBz/g7B0AIMVtPkX6kMu59YPBadlEyBuM FQF2p+kRwFoecg5nfEGOocMnL5tUqrba1mQGA9Vfuqpjh/BsagGOYnQzCwHt7+h5XFOb xfmVVCQ4cXKEpESLS4Di0RDcO629CVyZPLD6k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777394849; x=1777999649; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lsaS50fJFWEgKS/X3mmwXYg/L5d5/h6qIX6nFemmP8U=; b=kQp3RsRmn9y07QutIlEL6kzUaU9/4GaP/m7GoClVLczmJJeCh2k0rs9iaLXEiHwXHd +Hk7F0OAS56Q+UX2TIWewtOq/Bzub7JVLJ6PUahMp7TJ+7wbqlKicGJ6VRMA61vPZwKp EBZar1pzAVM4oNHp81tC6EDebjiryL0xvpK5Ybg9qCsGz9o3QQo1eIi9gjvOKBMrlTz2 p8KvGR+uJcB/fWDoYHckCsg3RrGUVHRFdUF8/17DzLgw50cPrqEhX/J+oITnxSGj4jXN U3msH7rwji5Qi6DymlsjlZ/q41bkv3wgOflYCUL8wjblI9R0P26VyBktJaRgmKgnwdHK Rbzw== X-Forwarded-Encrypted: i=1; AFNElJ8JjOjAwHgThtgCrEgFsMkX09j1CXoQi1FrNDA/PA+UmhOEuUUAlqt5/3f3/YfVhhDYWW6AvlE=@vger.kernel.org X-Gm-Message-State: AOJu0Yw/J76hA219cexudyVowO/+N3wwB/uVIqX8LHKlzN2nMF8iRg8s 2BfayjRGM7kfwmhFl8zYsJcIyP9SM2I9+0bIqbBQyhnkXl5hEZfkZ+vxuT7LtjEpow== X-Gm-Gg: AeBDiesDNx79yc851jcCug14UJR7yZhL9d7d7Wds0h78P0Ivc5H9AAtKKYf9pLDIt3X bpgFoiZWThRFhaGucxKIKuWLqxzRWoYezPhVJzBHGMrpZZnd/PCwZNf9I+pCNcfMbC4spbxB3/o 3JFYWpVqWwAxMNXoFCHZuDZLPKP8CZoQtZYanS148q6KKQcxanRrmHR0SeQwVb1WGXHiK0HgDmx b2EVcMRJxP3v5NrART2k8V5VhBXLgEtbTCjaCNPFDXYsm09dBZjAj9mulPuvJcbG6SNtPXFFYGX nGMwn6kRVOakh2QH/sTE42gdDmGPVuXoj0QDJOPgockl2zL67/zKBD9tJJ4qYFFlPEbrreOdOdE oN35uIKc/cP0PtlYVe90V2fyzyhTnKczti5XUntmQlqwOgAdtZ5bjiYTnxBH305VaJBdQrenlPn XQ3ZvEfduM04NGp+MD4sV3S+K7+ZZGkiUQsLj2aS4YObZVHqNCs2ju8eemEj7pfi4qZym1 X-Received: by 2002:a05:6871:e78f:b0:42f:ba47:36f5 with SMTP id 586e51a60fabf-433f396963emr2135147fac.17.1777394849189; Tue, 28 Apr 2026 09:47:29 -0700 (PDT) Received: from [172.22.22.28] (c-75-72-117-212.hsd1.mn.comcast.net. [75.72.117.212]) by smtp.googlemail.com with ESMTPSA id 586e51a60fabf-433efbf1d8dsm2255892fac.6.2026.04.28.09.47.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Apr 2026 09:47:28 -0700 (PDT) Message-ID: Date: Tue, 28 Apr 2026 11:47:26 -0500 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/4] net: ipa: Use the unified QMI service ID instead of defining it locally To: Daniel Lezcano , konradybcio@kernel.org, andersson@kernel.org Cc: linux-kernel@vger.kernel.org, Alex Elder , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jeff Johnson , Mathieu Poirier , Srinivas Kandagatla , Jaroslav Kysela , Takashi Iwai , Kees Cook , Greg Kroah-Hartman , Arnd Bergmann , Mark Brown , Wesley Cheng , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, ath11k@lists.infradead.org, ath12k@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-sound@vger.kernel.org, Dmitry Baryshkov References: <20260316171419.2619620-1-daniel.lezcano@oss.qualcomm.com> <20260316171419.2619620-2-daniel.lezcano@oss.qualcomm.com> Content-Language: en-US From: Alex Elder In-Reply-To: <20260316171419.2619620-2-daniel.lezcano@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/16/26 12:14 PM, Daniel Lezcano wrote: > Instead of defining a local macro with a custom name for the QMI > service identifier, use the one provided in qmi.h and remove the > locally defined macro. > > Reviewed-by: Dmitry Baryshkov > Signed-off-by: Daniel Lezcano Looks good! Reviewed-by: Alex Elder > --- > drivers/net/ipa/ipa_qmi.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/ipa/ipa_qmi.c b/drivers/net/ipa/ipa_qmi.c > index d771f3a71f94..37936ad132a2 100644 > --- a/drivers/net/ipa/ipa_qmi.c > +++ b/drivers/net/ipa/ipa_qmi.c > @@ -66,11 +66,9 @@ > * determination of when things are "ready" > */ > > -#define IPA_HOST_SERVICE_SVC_ID 0x31 > #define IPA_HOST_SVC_VERS 1 > #define IPA_HOST_SERVICE_INS_ID 1 > > -#define IPA_MODEM_SERVICE_SVC_ID 0x31 > #define IPA_MODEM_SERVICE_INS_ID 2 > #define IPA_MODEM_SVC_VERS 1 > > @@ -484,7 +482,7 @@ int ipa_qmi_setup(struct ipa *ipa) > if (ret) > return ret; > > - ret = qmi_add_server(&ipa_qmi->server_handle, IPA_HOST_SERVICE_SVC_ID, > + ret = qmi_add_server(&ipa_qmi->server_handle, QMI_SERVICE_ID_IPA, > IPA_HOST_SVC_VERS, IPA_HOST_SERVICE_INS_ID); > if (ret) > goto err_server_handle_release; > @@ -501,7 +499,7 @@ int ipa_qmi_setup(struct ipa *ipa) > /* We need this ready before the service lookup is added */ > INIT_WORK(&ipa_qmi->init_driver_work, ipa_client_init_driver_work); > > - ret = qmi_add_lookup(&ipa_qmi->client_handle, IPA_MODEM_SERVICE_SVC_ID, > + ret = qmi_add_lookup(&ipa_qmi->client_handle, QMI_SERVICE_ID_IPA, > IPA_MODEM_SVC_VERS, IPA_MODEM_SERVICE_INS_ID); > if (ret) > goto err_client_handle_release;