From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2F63C6FD19 for ; Thu, 16 Mar 2023 13:16:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229904AbjCPNQR (ORCPT ); Thu, 16 Mar 2023 09:16:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57240 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229659AbjCPNQQ (ORCPT ); Thu, 16 Mar 2023 09:16:16 -0400 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E24B62737 for ; Thu, 16 Mar 2023 06:16:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678972573; x=1710508573; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=+ZA6ECV8/HtWNzfF9VUt86aQNnZRCYLUSOdu+1z5msI=; b=X0lCxfD3i8UajjEkmR0T/2NpCoTuf12Ken+XTum040Zlu/7kuU4J96Ku PoK7LGzfsy4o3orPfR1sg0ZvTSmtLpyCoRWrLufCDNzc2hEfaAobqzjHY rwnzgg20jnuH4WSlWN+yotzcTa37dPstHkvWjlHV23r5VURx+8I2I470u FdvRGw3nSa9glp7azQDHT4lG1cb76JKeQMNwminj7951IKInMqic+Ok49 rhnDbHXljU7NwArxV+Fan12kaCV1GXYFy7whH6VqY4pQSSumokFJtA5v+ ruk69CPAufuoNHATzrPgN1BQcRmy9lPZDTU/awfYnW05DK7W8ZbOW7WdB A==; X-IronPort-AV: E=McAfee;i="6600,9927,10650"; a="336674512" X-IronPort-AV: E=Sophos;i="5.98,265,1673942400"; d="scan'208";a="336674512" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2023 06:15:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10650"; a="682308469" X-IronPort-AV: E=Sophos;i="5.98,265,1673942400"; d="scan'208";a="682308469" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga007.fm.intel.com with ESMTP; 16 Mar 2023 06:15:45 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Thu, 16 Mar 2023 06:15:45 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Thu, 16 Mar 2023 06:15:45 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Thu, 16 Mar 2023 06:15:45 -0700 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.46) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Thu, 16 Mar 2023 06:15:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oUUeha3R4v/bzzVPalvfaWdT03LD0UAC2igVWkPYwVWg2LY0cxYaHgDzYxn3WyRdsKy23TZ+iydPHqAt4aOjPZqYVDaDKlHSCI5dvCdDXKSUmLsBpFo0DStrAn86rcxtto8g6Hc2xkEqutPtu7AtzptXzMQP9M73IUewPStoeZSEk3NFhW7Iex4p851zIIZdgMol5WtlVOC2oN+2ahxyr9n0bRUK8D8nHrc/8xJgGDG4e2luc9Y+W/gFy2JVtQUPh+xIpMkrmwW3jLZCPp9pu4Z+g4Uk8HM98gk53jSUUJnl0F+YpU32j5NUoDD8OyViRAVo8HsGK/ZO4Qv0gGM9Dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5f+kxnCtN6h2ky4J44gzk4O38KcXbCGRKJSsniHL1gY=; b=e46On6BF9FMbx/WpmWkR6fLrHPM+8DvDt1nCIAb6MbkuYRqgo/2Pfl8GEjRGhpaez9fSjHNtrnZZiX9zp/ZqQZcWeO3Fkh0NX//0aUY2nmYD6EziQIK7097XhSYWWrB+Cnb2nAEnHpalYICZ1ZUQZ55afmM56NMpK/xG2PHJjGNxHvI7+mYRvNEeHN6lcDauTXPhZ0fNSn/9kLx3cgXn2Md+Cw9PdMeuEX/p+yrisIEQHkCEZ/Gj+fSrR7lq5/egjMTjd5qjtoiLch36iNzdtXovOGV1bkFHsx4qnv3/oYe76aKbhRuq3JAc9FBp0z2wJpHMLogqWH4VNm5Um0/A5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from SJ0PR11MB6695.namprd11.prod.outlook.com (2603:10b6:a03:44e::6) by IA1PR11MB7341.namprd11.prod.outlook.com (2603:10b6:208:426::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.29; Thu, 16 Mar 2023 13:15:41 +0000 Received: from SJ0PR11MB6695.namprd11.prod.outlook.com ([fe80::25a3:92a0:1379:9e00]) by SJ0PR11MB6695.namprd11.prod.outlook.com ([fe80::25a3:92a0:1379:9e00%3]) with mapi id 15.20.6178.029; Thu, 16 Mar 2023 13:15:41 +0000 Message-ID: Date: Thu, 16 Mar 2023 07:15:32 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH net 3/3] iavf: do not track VLAN 0 filters To: Leon Romanovsky , Tony Nguyen CC: , , , , , Michal Kubiak , Rafal Romanowski References: <20230314174423.1048526-1-anthony.l.nguyen@intel.com> <20230314174423.1048526-4-anthony.l.nguyen@intel.com> <20230315084856.GN36557@unreal> Content-Language: en-US From: Ahmed Zaki In-Reply-To: <20230315084856.GN36557@unreal> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0017.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::20) To SJ0PR11MB6695.namprd11.prod.outlook.com (2603:10b6:a03:44e::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR11MB6695:EE_|IA1PR11MB7341:EE_ X-MS-Office365-Filtering-Correlation-Id: 8702dc78-039b-4500-97ac-08db26208a94 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RhLoLmOtVlPxzJ0mfPIbykDf3AC3TaAXEi8ErYFMWyh0T1Wk7lTQG62tjeDXkQaNFFWRrOCRePhf6t/jIbNOa/+KbqICPXTDIy0fFsgQG+GkY6vXPOZmJvNGshIYO6QiOW/cCU8bOh986plPrzqgFAzS9/RCUIEBaVn23gMtxwSquPYSqH4y/mheWAvtn6UBDihK+PMOyaKHvTtTVDAAqxYq0g4lkN45cbUM2jJHezj/7gQpdkZuwFqHf1EUfup/we3aSflmt5OgruzBvVKh+BXLhxP7zYKijz89jOMyUU6xJpUfO/8dLQQu6Ek67UMkRaQwVyfU2R28ILn78xLPmNqT0w99Ah6f95ZMfSPhC1lDBEc2Rh7fPp+9KevfWCeiCt96tqMCZCigTBzwhOryYpXSVZvRulEIyNhH+1coqPNbG1MjpirUBIq/LGAYpD+/OmlYoTszZsrPioLduedP7Iw82DBC/Lnn//n6q+3Fn+iTu+7TAtPQsYsop5vnd3+JGboBhYb4/hDjcBNFZGG/k9C9ObqfbqHjl0jNKOcurN6j4ZxPMX8O0Ev5QQ/gshiRnnq+h+rfy3gNC7PUDsqEXrc/8IG3gEY3gW8LLyeMxr61i2Pd9KMcP52WT1rNQasm1pfF/FAKWi2l0SRjzqmlMuD+KgLeUOnMwpvZvPX3ZtlAonRl6ugJNVVAWcyhqsj/fDkfgzy6UD+/DpjmRjXwbmbnNq4lFxtuZlV9bD2Ao/g= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR11MB6695.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(39860400002)(396003)(136003)(376002)(366004)(346002)(451199018)(36756003)(86362001)(31696002)(478600001)(186003)(4326008)(5660300002)(8936002)(41300700001)(66476007)(44832011)(6636002)(110136005)(66556008)(316002)(54906003)(8676002)(66946007)(2906002)(38100700002)(83380400001)(6666004)(53546011)(107886003)(26005)(6512007)(6486002)(82960400001)(2616005)(31686004)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bUJpT2JoNlJWeTE5V1BUaTBVakIwOHJTNVhQUDBwRmplRU9Zak5Rb2tvZGdt?= =?utf-8?B?YWFCZDRYOHA1blhldTZOcGZSdm5RVTkwQitoMlZrZCsvS3V6eE5ZazMzTXZr?= =?utf-8?B?eDNuY3RZcm05K0ZBMktCK2JWeWU2UU1GeHJ6RmE0YWRuQnptTFdkYTl6RmVk?= =?utf-8?B?Nmpsa2U1bDJXczRKK3NlNUMxMWVmSjY0aUkzREZhQjdFWURrNjBCeVZrQ2s0?= =?utf-8?B?ZmdScmRkejJXUFRka3E1QUJLQWpGQ1BVREdlUU9rWHY5MzE0SlNpNS85QllB?= =?utf-8?B?VHYxK3ZmWStNUUFiYlIyT0RWQzB1YU5CODEwcEpjaXBRdG9BZHRaTE9iR2dT?= =?utf-8?B?Ry9HaFhvZnVMZ1E2cGdhWVE0Vnc1eVBzK1hzVTd2VG1Bd3YweFBLVmZzQTBY?= =?utf-8?B?NVVwVk0xTENiSUJyM1JySmFWWjI5L3o3R1hWZVlKK1JaUzdpNFF2RHh1aCtw?= =?utf-8?B?U0luSEFqM1F6VENiejVzWjN5RkVCN2lSTkI5VHBPSVhSeEhkaW9xZ0tYSUNO?= =?utf-8?B?WVJvd01kbDlBRmY2NlFtMzFlc0pDc3QyclFyRUhYZ2NmWUFGVURUdVFmRkNP?= =?utf-8?B?OGszY1ZmaENoLzgyV2JBcW5jL0FTZGt4S1d2S21zeDRiVXp5dEZMMFZ5TTJh?= =?utf-8?B?WkdsMEZzWDhGYkx6K3psL1lMMUt0QVNmQXQ2RFZrR2g3aytLaWJlUXZMall3?= =?utf-8?B?bm9mZDhHQXZUWTV6VFFDSWRRYlVsUkpBQ1l2K0lrMEJWcElkaURqZDdBMG1q?= =?utf-8?B?YnpFTVk4UEJEeFhqU09MZzJNMTF4a01QdklNM25PNWdWL21keS9PY0orQUZx?= =?utf-8?B?Znh4ZzNDbEtLRWVkUlBMYTBCS1cwL3E0YXd2Slk1clJqbFFiaDRmZVlvbEVU?= =?utf-8?B?TmVXbFhxYVNvZE5CWjlybE5tcjBFTXlWMnJYeFNWYTBpZ2xSSUF6SWZERkRZ?= =?utf-8?B?VlZqV295aDJFTjlSVFVBY1BqSmZGeTZvK0RCbE5XVEJ5ZkV5NytacHJIYVVD?= =?utf-8?B?MlFRK3owVjZnMXVKS2xySEdqM1BPTTRMQzVYWG9oeVlnK0gyUGlTdFBjNzVq?= =?utf-8?B?Q0k5eGdxMjRlUHBObzB0SFRMdkFMcEFKQlVkcGpWdGFWMEtNdmFWOS9IU3lH?= =?utf-8?B?cFpJa0FMVHNPeHorVkE1RHRCMmlGejZJdHlVWG5nVENHWDJOU1VpOWFEa1RN?= =?utf-8?B?ekpUUjA4WjlKVFVDdmxqM2FJN3kwaGxuekx5ZXo1cCtPOW44WXdHWUN5MGU3?= =?utf-8?B?Ni9HdHRWSWRYQWt6NUl0Mm9SRHlZTXFMSmJTUitIaCtEcVJ1Y09Va3k4TTEw?= =?utf-8?B?UHZTN0FVQUkzTEZDNE9jdnNpbktCTTdMUnRSaTBQeTBsY1MzcTVnaTdlKzN3?= =?utf-8?B?V1ZKb2p5OEVuVFRkWjN5MFJkU2xEVk0yQ0dFMU5TNVM1bVRPWWtOaDRZanM5?= =?utf-8?B?OFJlYzBqNTFheEc3RGpPVzJibkYxY0NNQ0RjZTJKa1pXU3p1RFY5dktrT1pz?= =?utf-8?B?aGFjZ2pNUjlTcTBJOU5nUkJVMlNmMzBKbGhPTFhIbEljYlJyeXNSNmFXNW9F?= =?utf-8?B?UkVESit6OElUUlJuWXU2OU5iRy9yTHNjdjRsd2hjdVVycnFQSVhWR2wweVBj?= =?utf-8?B?NDVrUEZKL2dXTHFkVUIyTVo1TnA2RG1ZMTY1bG5RSzM2dDN2b2hUREptOGho?= =?utf-8?B?dFZVZFIraDZjSHZJV012WU1Wa0hnMUNtL0lqdHYrU0dYV1NWY1h1N2E1ZEYy?= =?utf-8?B?NkNJbHlYNXE5OW1Sb2VUYnM2Z3MxWTcyclhlYXVvNDIzdHZmbEZBSW9uamRl?= =?utf-8?B?bVhSZ3drNWhwcnpCVjcyTldBSUtYZWlTVkVvR3pZUlJ1d2hoQTNsUEVNakZa?= =?utf-8?B?eWVpaGpEV0c0MVR2VVVHRjNmUS9BaForSzUyZDZMWUtCWFcwZTZZZHo0eGFa?= =?utf-8?B?SEVCbnlIQjlMTUJqbWtvZ0pndGFzcjRDVmltcmdFZmY2ZUE4TlVjNy9udjFl?= =?utf-8?B?MUtLdmRXWGJ6OWFBdjJqcFBBR3doK0JWRlNGVFNDWm8zV2JMK3JHa0lsVGY2?= =?utf-8?B?c3Fkd3hjdUNFK2tmeWZyZ0NOdkkycWozck9mMjdrVXc4Q2RUeWh2My9zaXll?= =?utf-8?B?NkJBSmEwWmdxc1VxdHZqQXNmM01LZlRNa3FidDE0TzA0SjM1TnI3aThNRDdY?= =?utf-8?B?dUE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 8702dc78-039b-4500-97ac-08db26208a94 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB6695.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2023 13:15:41.2445 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Sgn6iux/IJJYLY8vmSyywAC7Gqs/hROAMwdyGqcl1QkqsHBy0ke07lK1IlprbqsF+RfoaL4Nn4oAVCRQWzcT2w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7341 X-OriginatorOrg: intel.com Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2023-03-15 02:48, Leon Romanovsky wrote: > On Tue, Mar 14, 2023 at 10:44:23AM -0700, Tony Nguyen wrote: >> From: Ahmed Zaki >> >> When an interface with the maximum number of VLAN filters is brought up, >> a spurious error is logged: >> >> [257.483082] 8021q: adding VLAN 0 to HW filter on device enp0s3 >> [257.483094] iavf 0000:00:03.0 enp0s3: Max allowed VLAN filters 8. Remove existing VLANs or disable filtering via Ethtool if supported. >> >> The VF driver complains that it cannot add the VLAN 0 filter. >> >> On the other hand, the PF driver always adds VLAN 0 filter on VF >> initialization. The VF does not need to ask the PF for that filter at >> all. >> >> Fix the error by not tracking VLAN 0 filters altogether. With that, the >> check added by commit 0e710a3ffd0c ("iavf: Fix VF driver counting VLAN 0 >> filters") in iavf_virtchnl.c is useless and might be confusing if left as >> it suggests that we track VLAN 0. >> >> Fixes: 0e710a3ffd0c ("iavf: Fix VF driver counting VLAN 0 filters") >> Signed-off-by: Ahmed Zaki >> Reviewed-by: Michal Kubiak >> Tested-by: Rafal Romanowski >> Signed-off-by: Tony Nguyen >> --- >> drivers/net/ethernet/intel/iavf/iavf_main.c | 4 ++++ >> drivers/net/ethernet/intel/iavf/iavf_virtchnl.c | 2 -- >> 2 files changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c >> index 3273aeb8fa67..eb8f944276ff 100644 >> --- a/drivers/net/ethernet/intel/iavf/iavf_main.c >> +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c >> @@ -893,6 +893,10 @@ static int iavf_vlan_rx_add_vid(struct net_device *netdev, >> { >> struct iavf_adapter *adapter = netdev_priv(netdev); >> >> + /* Do not track VLAN 0 filter, always added by the PF on VF init */ >> + if (!vid) >> + return 0; > I would expect similar check in iavf_vlan_rx_kill_vid(), > > Thanks Thanks for review. Next version will include the check in iavf_vlan_rx_kill_vid() > >> + >> if (!VLAN_FILTERING_ALLOWED(adapter)) >> return -EIO; >> >> diff --git a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c b/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c >> index 6d23338604bb..4e17d006c52d 100644 >> --- a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c >> +++ b/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c >> @@ -2446,8 +2446,6 @@ void iavf_virtchnl_completion(struct iavf_adapter *adapter, >> list_for_each_entry(f, &adapter->vlan_filter_list, list) { >> if (f->is_new_vlan) { >> f->is_new_vlan = false; >> - if (!f->vlan.vid) >> - continue; >> if (f->vlan.tpid == ETH_P_8021Q) >> set_bit(f->vlan.vid, >> adapter->vsi.active_cvlans); >> -- >> 2.38.1 >>