From: Jiri Slaby <jirislaby@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: jesse.brandeburg@intel.com, linux-kernel@vger.kernel.org,
Martin Liska <mliska@suse.cz>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org
Subject: Re: [PATCH] i40e (gcc13): synchronize allocate/free functions return type & values
Date: Thu, 3 Nov 2022 13:03:41 +0100 [thread overview]
Message-ID: <bf584d22-8aca-3867-5e3a-489d62a61929@kernel.org> (raw)
In-Reply-To: <20221102204110.26a6f021@kernel.org>
On 03. 11. 22, 4:41, Jakub Kicinski wrote:
> On Mon, 31 Oct 2022 12:44:56 +0100 Jiri Slaby (SUSE) wrote:
>> I.e. the type of their return value in the definition is int, while the
>> declaration spell enum i40e_status. Synchronize the definitions to the
>> latter.
>>
>> And make sure proper values are returned. I.e. I40E_SUCCESS and not 0,
>> I40E_ERR_NO_MEMORY and not -ENOMEM.
>
> Let's go the opposite way, towards using standard errno.
This is propagated several layers up throughout the whole i40e driver.
It would be a mass change which I'd rather leave up to the driver
maintainers -- I don't even have the HW to test.
thanks,
--
js
next prev parent reply other threads:[~2022-11-03 12:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-31 11:44 [PATCH] i40e (gcc13): synchronize allocate/free functions return type & values Jiri Slaby (SUSE)
2022-11-03 3:41 ` Jakub Kicinski
2022-11-03 12:03 ` Jiri Slaby [this message]
2022-11-04 18:33 ` Tony Nguyen
2022-11-04 18:47 ` Jakub Kicinski
2022-11-04 20:28 ` Tony Nguyen
2022-12-12 11:55 ` Jiri Slaby
2022-12-12 17:51 ` Tony Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf584d22-8aca-3867-5e3a-489d62a61929@kernel.org \
--to=jirislaby@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mliska@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).