From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Pawe=c5=82_Staszewski?= Subject: Re: Huge memory leak with 4.15.0-rc2+ Date: Mon, 11 Dec 2017 23:27:52 +0100 Message-ID: References: <2353c149-cae1-f986-63d0-3568534a1e8c@itcare.pl> <65a3563d-396e-e4fb-7dad-937ce999868e@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit To: John Fastabend , Linux Kernel Network Developers Return-path: Received: from smtp12.iq.pl ([86.111.240.243]:44540 "EHLO smtp12.iq.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751831AbdLKW1u (ORCPT ); Mon, 11 Dec 2017 17:27:50 -0500 In-Reply-To: <65a3563d-396e-e4fb-7dad-937ce999868e@gmail.com> Content-Language: pl Sender: netdev-owner@vger.kernel.org List-ID: W dniu 2017-12-11 o 23:15, John Fastabend pisze: > On 12/11/2017 01:48 PM, Paweł Staszewski wrote: >> >> W dniu 2017-12-11 o 22:23, Paweł Staszewski pisze: >>> Hi >>> >>> >>> I just upgraded some testing host to 4.15.0-rc2+ kernel >>> >>> And after some time of traffic processing - when traffic on all ports >>> reach about 3Mpps - memleak started. >>> > > [...] > >>> Some observations - when i disable tso on all cards there is more >>> memleak. >>> >>> >>> >>> >>> >> When traffic starts to drop - there is less and less memleak >> below link to memory usage graph: >> https://ibb.co/hU97kG >> >> And there is rising slab_unrecl - Amount of unreclaimable memory used >> for slab kernel allocations >> >> >> Forgot to add that im using hfsc and qdiscs like pfifo on classes. >> >> > Maybe some error case I missed in the qdisc patches I'm looking into > it. > > Thanks, > John > > This is how it looks like when corelated on graph - traffic vs mem https://ibb.co/njpkqG Typical hfsc class + qdisc: ### Client interface vlan1616 tc qdisc del dev vlan1616 root tc qdisc add dev vlan1616 handle 1: root hfsc default 100 tc class add dev vlan1616 parent 1: classid 1:100 hfsc ls m2 200Mbit ul m2 200Mbit tc qdisc add dev vlan1616 parent 1:100 handle 100: pfifo limit 128 ### End TM for client interface tc qdisc del dev vlan1616 ingress tc qdisc add dev vlan1616 handle ffff: ingress tc filter add dev vlan1616 parent ffff: protocol ip prio 50 u32 match ip src 0.0.0.0/0 police rate 200Mbit burst 200M mtu 32k drop flowid 1:1 And this is same for about 450 vlan interfaces Good thing is that compared to 4.14.3 i have about 5% less cpu load on 4.15.0-rc2+ When hfsc will be lockless or tbf - then it will be really huge difference in cpu load on x86 when using traffic shaping - so really good job John.