From: Florian Fainelli <f.fainelli@gmail.com>
To: "Rafał Miłecki" <zajec5@gmail.com>,
"Network Development" <netdev@vger.kernel.org>
Subject: Re: bgmac regression: hang while probing on BCM47189
Date: Mon, 20 Sep 2021 08:58:15 -0700 [thread overview]
Message-ID: <bfac8ad8-a90e-f075-5ec9-a91f678423be@gmail.com> (raw)
In-Reply-To: <CACna6ryn-gmGm0uKEd_gfNgLkGTNdKi=J=Akz5tp4nZGcZB9gQ@mail.gmail.com>
On 9/20/21 5:44 AM, Rafał Miłecki wrote:
> Hi,
>
> commit 34322615cbaa ("net: bgmac: Mask interrupts during probe")
> caused a regression on my Tenda AC9 router (BCM47189 SoC that belongs
> to the BCM53573 family).
>
> Calling bgmac_chip_intrs_off() that early in a probe function - for
> the *second* eth interface - simply hangs my device.
>
> I didn't see any problems caused by not having that call in the first place.
> A solution seems to be also to call bgmac_clk_enable() *first*.
>
> Should that call to the bgmac_chip_intrs_off() be conditional? Or
> should we reorder bgmac_chip_intrs_off() and bgmac_clk_enable()?
>
Most definitively, clocks should always be turned on prior to any
register access. On most platforms people don't even notice because the
boot loader does not care to shut down the Ethernet controller's clock
at all.
Do you mind submitting a fix for that? Thanks!
--
Florian
prev parent reply other threads:[~2021-09-20 15:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 12:44 bgmac regression: hang while probing on BCM47189 Rafał Miłecki
2021-09-20 15:58 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bfac8ad8-a90e-f075-5ec9-a91f678423be@gmail.com \
--to=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).