* bgmac regression: hang while probing on BCM47189
@ 2021-09-20 12:44 Rafał Miłecki
2021-09-20 15:58 ` Florian Fainelli
0 siblings, 1 reply; 2+ messages in thread
From: Rafał Miłecki @ 2021-09-20 12:44 UTC (permalink / raw)
To: Florian Fainelli, Network Development
Hi,
commit 34322615cbaa ("net: bgmac: Mask interrupts during probe")
caused a regression on my Tenda AC9 router (BCM47189 SoC that belongs
to the BCM53573 family).
Calling bgmac_chip_intrs_off() that early in a probe function - for
the *second* eth interface - simply hangs my device.
I didn't see any problems caused by not having that call in the first place.
A solution seems to be also to call bgmac_clk_enable() *first*.
Should that call to the bgmac_chip_intrs_off() be conditional? Or
should we reorder bgmac_chip_intrs_off() and bgmac_clk_enable()?
--
Rafał
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: bgmac regression: hang while probing on BCM47189
2021-09-20 12:44 bgmac regression: hang while probing on BCM47189 Rafał Miłecki
@ 2021-09-20 15:58 ` Florian Fainelli
0 siblings, 0 replies; 2+ messages in thread
From: Florian Fainelli @ 2021-09-20 15:58 UTC (permalink / raw)
To: Rafał Miłecki, Network Development
On 9/20/21 5:44 AM, Rafał Miłecki wrote:
> Hi,
>
> commit 34322615cbaa ("net: bgmac: Mask interrupts during probe")
> caused a regression on my Tenda AC9 router (BCM47189 SoC that belongs
> to the BCM53573 family).
>
> Calling bgmac_chip_intrs_off() that early in a probe function - for
> the *second* eth interface - simply hangs my device.
>
> I didn't see any problems caused by not having that call in the first place.
> A solution seems to be also to call bgmac_clk_enable() *first*.
>
> Should that call to the bgmac_chip_intrs_off() be conditional? Or
> should we reorder bgmac_chip_intrs_off() and bgmac_clk_enable()?
>
Most definitively, clocks should always be turned on prior to any
register access. On most platforms people don't even notice because the
boot loader does not care to shut down the Ethernet controller's clock
at all.
Do you mind submitting a fix for that? Thanks!
--
Florian
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-20 15:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-09-20 12:44 bgmac regression: hang while probing on BCM47189 Rafał Miłecki
2021-09-20 15:58 ` Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).