From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nikolay Aleksandrov Subject: Re: [PATCH net-next v4] net: ipv4: add support for ECMP hash policy choice Date: Thu, 16 Mar 2017 18:49:20 +0200 Message-ID: References: <1488884508-14016-1-git-send-email-nikolay@cumulusnetworks.com> <1489670880-12717-1-git-send-email-nikolay@cumulusnetworks.com> <20170316094152.0ac70537@xeon-e3> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, davem@davemloft.net, roopa@cumulusnetworks.com, dsa@cumulusnetworks.com, jkbs@redhat.com, edumazet@google.com, pch@ordbogen.com, nicolas.dichtel@6wind.com To: Stephen Hemminger Return-path: Received: from mail-wr0-f175.google.com ([209.85.128.175]:34427 "EHLO mail-wr0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753873AbdCPQt3 (ORCPT ); Thu, 16 Mar 2017 12:49:29 -0400 Received: by mail-wr0-f175.google.com with SMTP id l37so36220818wrc.1 for ; Thu, 16 Mar 2017 09:49:27 -0700 (PDT) In-Reply-To: <20170316094152.0ac70537@xeon-e3> Sender: netdev-owner@vger.kernel.org List-ID: On 16/03/17 18:41, Stephen Hemminger wrote: > On Thu, 16 Mar 2017 15:28:00 +0200 > Nikolay Aleksandrov wrote: > >> diff --git a/net/ipv4/sysctl_net_ipv4.c b/net/ipv4/sysctl_net_ipv4.c >> index d6880a6149ee..62c4f94923e5 100644 >> --- a/net/ipv4/sysctl_net_ipv4.c >> +++ b/net/ipv4/sysctl_net_ipv4.c >> @@ -1004,6 +1004,15 @@ static struct ctl_table ipv4_net_table[] = { >> .extra1 = &zero, >> .extra2 = &one, >> }, >> + { >> + .procname = "fib_multipath_hash_policy", >> + .data = &init_net.ipv4.sysctl_fib_multipath_hash_policy, >> + .maxlen = sizeof(int), >> + .mode = 0644, >> + .proc_handler = proc_dointvec_minmax, >> + .extra1 = &zero, >> + .extra2 = &one, >> + > > Rather than having magic integer values, it would be better to use > strings (like TCP congestion control). Especially if you want to support > more values in the future. With strings we'll need two sysctls - one to export the available ones, and one to set. I too am not happy with plain integers as I've said in v1 of this patch but if people are okay with having two new sysctls exported then I don't mind reworking it with strings. Or any other ideas are welcome. > > Also what about IPv6? > Patches are welcome, too. :-) We can update it at any time, IPv4 and 6 have been different for a very long time and it's not the point of this patch to bring them closer, though IPv6 already does L4 by default.