From: David Ahern <dsahern@gmail.com>
To: Ido Schimmel <idosch@mellanox.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
Jiri Pirko <jiri@mellanox.com>,
Alexander Petrovskiy <alexpe@mellanox.com>,
mlxsw <mlxsw@mellanox.com>
Subject: Re: [PATCH net-next 1/2] mlxsw: spectrum_router: Offload blackhole routes
Date: Fri, 8 Feb 2019 08:24:49 -0800 [thread overview]
Message-ID: <bfc7715f-a762-0ad7-9cb2-3c248eefad9e@gmail.com> (raw)
In-Reply-To: <20190208073408.GA26396@splinter>
On 2/7/19 11:34 PM, Ido Schimmel wrote:
>
> Yes. This patch configures the route itself to drop packets, but we can
> instead configure it as a remote route and configure the adjacency entry
> to drop packets.
>
> If you later want to change X routes using this blackhole nexthop to a
> different one, then create the new one and tell the hardware to do the
> switch in a single operation. It will basically grep over all configured
> routes and do:
>
> s/blackhole_adjacency_index/new_adjacency_index/
> s/black_ecmp_size/new_ecmp_size/
>
> See RALEU in drivers/net/ethernet/mellanox/mlxsw/reg.h
Thanks for the reference.
>
> I assume that user can't put blackhole and normal nexthops in the same
> group?
>
I allow a nexthop group to reference a nexthop that is a blackhole, but
the group can only contain the one entry. That allows multipath routes
to toggle between a blackhole and a real spec.
next prev parent reply other threads:[~2019-02-08 16:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-06 19:42 [PATCH net-next 0/2] mlxsw: Offload blackhole routes Ido Schimmel
2019-02-06 19:42 ` [PATCH net-next 1/2] mlxsw: spectrum_router: " Ido Schimmel
2019-02-08 0:40 ` David Ahern
2019-02-08 7:34 ` Ido Schimmel
2019-02-08 16:24 ` David Ahern [this message]
2019-02-08 17:05 ` Ido Schimmel
2019-02-06 19:42 ` [PATCH net-next 2/2] selftests: mlxsw: Add a test for " Ido Schimmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bfc7715f-a762-0ad7-9cb2-3c248eefad9e@gmail.com \
--to=dsahern@gmail.com \
--cc=alexpe@mellanox.com \
--cc=davem@davemloft.net \
--cc=idosch@mellanox.com \
--cc=jiri@mellanox.com \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).