From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C037C282CB for ; Fri, 8 Feb 2019 16:24:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E13032086C for ; Fri, 8 Feb 2019 16:24:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Vs29oxht" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727981AbfBHQYz (ORCPT ); Fri, 8 Feb 2019 11:24:55 -0500 Received: from mail-pg1-f193.google.com ([209.85.215.193]:39249 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727203AbfBHQYw (ORCPT ); Fri, 8 Feb 2019 11:24:52 -0500 Received: by mail-pg1-f193.google.com with SMTP id r11so1780385pgp.6 for ; Fri, 08 Feb 2019 08:24:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=2qqqogj+8LVsXWLRv9Gh6lRP/BYFT9YaDGPJ3HVgKOg=; b=Vs29oxhtCmV2yqYSoeB6iuGgW8eMZ3/WuxpSYZedBHknJ6jbs9fvMfvVfJzoZ2dhpq 7WOWJAvvajiOrWualJs/EZiCUIzo5Ez1JYUOAZ0ztpUxJ+ZBoupfZ7ZVYgYxnaKE7f8j mXJXVbNoXg+JiYUr91XOBx1CkvxWXVW/Bb3Dt4rjay6a3P7up+nGfG/EMlh1WMMjV1gL f9FoJcl6UDHT9+ztnwhE1JFf1JfRyHA2s8PbDw4y1ZIXWgsFz0MyFcPzCeHUbrcBjaub 1H1S1f/cGsC57zArB6/h6MxuvIk9n2vnMJqI+Joojqe6ekCblSkECLqJmZxskOSFzCB/ Jiww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2qqqogj+8LVsXWLRv9Gh6lRP/BYFT9YaDGPJ3HVgKOg=; b=Qh6c1xRbTztgiJJA7d1vcmatEP7vImOqNWt6dH0BygQ+40lY+V6b8NPhLp6irolB5x MMSnnhl0VBSjhkxgjVXtm2H31mJdsJ5+vW86L8hw2Oc2UvGIJJkc0apRXMF905H5NOty CvnbMWapKOFtfGK9AtxA0pSDLRsEsfht9Mgm04WhZRkhumniRfkNp7t6Tqx4NGPe311J v4x4VPg71G0+hhYk5iXL3Ro/MfTIsD6lx1KX2K2xeSYPVYv80YuRI4IcrmGMZLCihkhN Y1iSvTxMAhrcKiQPurdiOpgDl4LGVmLHak+VtuiWAbiLzFMrHg39kCUW0T+1H+uyr2hW 5Uiw== X-Gm-Message-State: AHQUAuZnrNkCSkT9FA3vWyrsyLFZD4m5BUsOC87D9fx1kcs1CiG1hq2i poxv7Vg32c5H81frYRvKbVdx7JuJ X-Google-Smtp-Source: AHgI3IbExMAwjfjTM0kAycuzs9N+LK7I7zwN7opOsyxRKBoYJ1LtOtVGRwTjwwMazcO3aPrESImiAQ== X-Received: by 2002:a65:4c0f:: with SMTP id u15mr20304092pgq.225.1549643091613; Fri, 08 Feb 2019 08:24:51 -0800 (PST) Received: from [10.40.10.131] (fw.cumulusnetworks.com. [216.129.126.126]) by smtp.googlemail.com with ESMTPSA id o6sm2798442pgp.59.2019.02.08.08.24.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Feb 2019 08:24:50 -0800 (PST) Subject: Re: [PATCH net-next 1/2] mlxsw: spectrum_router: Offload blackhole routes To: Ido Schimmel Cc: "netdev@vger.kernel.org" , "davem@davemloft.net" , Jiri Pirko , Alexander Petrovskiy , mlxsw References: <20190206194140.18606-1-idosch@mellanox.com> <20190206194140.18606-2-idosch@mellanox.com> <18da8b4d-5966-e851-46d6-e389e40b865e@gmail.com> <20190208073408.GA26396@splinter> From: David Ahern Message-ID: Date: Fri, 8 Feb 2019 08:24:49 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190208073408.GA26396@splinter> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2/7/19 11:34 PM, Ido Schimmel wrote: > > Yes. This patch configures the route itself to drop packets, but we can > instead configure it as a remote route and configure the adjacency entry > to drop packets. > > If you later want to change X routes using this blackhole nexthop to a > different one, then create the new one and tell the hardware to do the > switch in a single operation. It will basically grep over all configured > routes and do: > > s/blackhole_adjacency_index/new_adjacency_index/ > s/black_ecmp_size/new_ecmp_size/ > > See RALEU in drivers/net/ethernet/mellanox/mlxsw/reg.h Thanks for the reference. > > I assume that user can't put blackhole and normal nexthops in the same > group? > I allow a nexthop group to reference a nexthop that is a blackhole, but the group can only contain the one entry. That allows multipath routes to toggle between a blackhole and a real spec.