* [PATCH net-next] net: phy: realtek: get rid of magic numbers in rtl8201_config_intr()
@ 2026-04-06 20:12 Aleksander Jan Bajkowski
2026-04-06 20:43 ` Daniel Golle
2026-04-06 20:44 ` Nicolai Buchwitz
0 siblings, 2 replies; 3+ messages in thread
From: Aleksander Jan Bajkowski @ 2026-04-06 20:12 UTC (permalink / raw)
To: andrew, hkallweit1, linux, davem, edumazet, kuba, pabeni, daniel,
vladimir.oltean, michael, olek2, markus.stockhausen, ih,
rmk+kernel, netdev, linux-kernel
Replace the magic numbers with defines. Register names were obtained from
publicly available documentation[1]. This should make it clear what's going
on in the code.
1. RTL8201F/RTL8201FL/RTL8201FN Rev. 1.4 Datasheet
Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>
---
drivers/net/phy/realtek/realtek_main.c | 15 ++++++++++++---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/drivers/net/phy/realtek/realtek_main.c b/drivers/net/phy/realtek/realtek_main.c
index 75565fbdbf6d..e78f3b9e89db 100644
--- a/drivers/net/phy/realtek/realtek_main.c
+++ b/drivers/net/phy/realtek/realtek_main.c
@@ -22,7 +22,14 @@
#include "../phylib.h"
#include "realtek.h"
+#define RTL8201F_IER_PAGE 0x07
#define RTL8201F_IER 0x13
+#define RTL8201F_IER_LINK BIT(13)
+#define RTL8201F_IER_DUPLEX BIT(12)
+#define RTL8201F_IER_ANERR BIT(11)
+#define RTL8201F_IER_MASK (RTL8201F_IER_ANERR | \
+ RTL8201F_IER_DUPLEX | \
+ RTL8201F_IER_LINK)
#define RTL8201F_ISR 0x1e
#define RTL8201F_ISR_ANERR BIT(15)
@@ -346,11 +353,13 @@ static int rtl8201_config_intr(struct phy_device *phydev)
if (err)
return err;
- val = BIT(13) | BIT(12) | BIT(11);
- err = phy_write_paged(phydev, 0x7, RTL8201F_IER, val);
+ val = RTL8201F_IER_MASK;
+ err = phy_write_paged(phydev, RTL8201F_IER_PAGE,
+ RTL8201F_IER, val);
} else {
val = 0;
- err = phy_write_paged(phydev, 0x7, RTL8201F_IER, val);
+ err = phy_write_paged(phydev, RTL8201F_IER_PAGE,
+ RTL8201F_IER, val);
if (err)
return err;
--
2.51.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: phy: realtek: get rid of magic numbers in rtl8201_config_intr()
2026-04-06 20:12 [PATCH net-next] net: phy: realtek: get rid of magic numbers in rtl8201_config_intr() Aleksander Jan Bajkowski
@ 2026-04-06 20:43 ` Daniel Golle
2026-04-06 20:44 ` Nicolai Buchwitz
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Golle @ 2026-04-06 20:43 UTC (permalink / raw)
To: Aleksander Jan Bajkowski
Cc: andrew, hkallweit1, linux, davem, edumazet, kuba, pabeni,
vladimir.oltean, michael, markus.stockhausen, ih, rmk+kernel,
netdev, linux-kernel
On Mon, Apr 06, 2026 at 10:12:12PM +0200, Aleksander Jan Bajkowski wrote:
> Replace the magic numbers with defines. Register names were obtained from
> publicly available documentation[1]. This should make it clear what's going
> on in the code.
>
> 1. RTL8201F/RTL8201FL/RTL8201FN Rev. 1.4 Datasheet
> Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>
Reviewed-by: Daniel Golle <daniel@makrotopia.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: phy: realtek: get rid of magic numbers in rtl8201_config_intr()
2026-04-06 20:12 [PATCH net-next] net: phy: realtek: get rid of magic numbers in rtl8201_config_intr() Aleksander Jan Bajkowski
2026-04-06 20:43 ` Daniel Golle
@ 2026-04-06 20:44 ` Nicolai Buchwitz
1 sibling, 0 replies; 3+ messages in thread
From: Nicolai Buchwitz @ 2026-04-06 20:44 UTC (permalink / raw)
To: Aleksander Jan Bajkowski
Cc: andrew, hkallweit1, linux, davem, edumazet, kuba, pabeni, daniel,
vladimir.oltean, michael, markus.stockhausen, ih, rmk+kernel,
netdev, linux-kernel
On 6.4.2026 22:12, Aleksander Jan Bajkowski wrote:
> Replace the magic numbers with defines. Register names were obtained
> from
> publicly available documentation[1]. This should make it clear what's
> going
> on in the code.
>
> 1. RTL8201F/RTL8201FL/RTL8201FN Rev. 1.4 Datasheet
> Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>
> ---
> drivers/net/phy/realtek/realtek_main.c | 15 ++++++++++++---
> 1 file changed, 12 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/phy/realtek/realtek_main.c
> b/drivers/net/phy/realtek/realtek_main.c
> index 75565fbdbf6d..e78f3b9e89db 100644
> --- a/drivers/net/phy/realtek/realtek_main.c
> +++ b/drivers/net/phy/realtek/realtek_main.c
> @@ -22,7 +22,14 @@
> #include "../phylib.h"
> #include "realtek.h"
>
> +#define RTL8201F_IER_PAGE 0x07
> #define RTL8201F_IER 0x13
> +#define RTL8201F_IER_LINK BIT(13)
> +#define RTL8201F_IER_DUPLEX BIT(12)
> +#define RTL8201F_IER_ANERR BIT(11)
> +#define RTL8201F_IER_MASK (RTL8201F_IER_ANERR | \
> + RTL8201F_IER_DUPLEX | \
> + RTL8201F_IER_LINK)
>
> #define RTL8201F_ISR 0x1e
> #define RTL8201F_ISR_ANERR BIT(15)
> @@ -346,11 +353,13 @@ static int rtl8201_config_intr(struct phy_device
> *phydev)
> if (err)
> return err;
>
> - val = BIT(13) | BIT(12) | BIT(11);
> - err = phy_write_paged(phydev, 0x7, RTL8201F_IER, val);
> + val = RTL8201F_IER_MASK;
> + err = phy_write_paged(phydev, RTL8201F_IER_PAGE,
> + RTL8201F_IER, val);
> } else {
> val = 0;
> - err = phy_write_paged(phydev, 0x7, RTL8201F_IER, val);
> + err = phy_write_paged(phydev, RTL8201F_IER_PAGE,
> + RTL8201F_IER, val);
> if (err)
> return err;
Matches the datasheet (RTL8201F/RTL8201FL/RTL8201FN Rev. 1.4 Datasheet)
Reviewed-by: Nicolai Buchwitz nb@tipi-net.de
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-04-06 20:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-06 20:12 [PATCH net-next] net: phy: realtek: get rid of magic numbers in rtl8201_config_intr() Aleksander Jan Bajkowski
2026-04-06 20:43 ` Daniel Golle
2026-04-06 20:44 ` Nicolai Buchwitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox