From: Heiner Kallweit <hkallweit1@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 2/2] r8169: use the generic EEE management functions
Date: Thu, 15 Aug 2019 15:02:32 +0200 [thread overview]
Message-ID: <bfd67eb3-0da7-b8a5-928a-a66802185b68@gmail.com> (raw)
In-Reply-To: <20190815123558.GA31172@lunn.ch>
On 15.08.2019 14:35, Andrew Lunn wrote:
> On Thu, Aug 15, 2019 at 11:47:33AM +0200, Heiner Kallweit wrote:
>> Now that the Realtek PHY driver maps the vendor-specific EEE registers
>> to the standard MMD registers, we can remove all special handling and
>> use the generic functions phy_ethtool_get/set_eee.
>
> Hi Heiner
>
Hi Andrew,
> I think you should also add a call the phy_init_eee()?
>
I think it's not strictly needed. And few things regarding
phy_init_eee are not fully clear to me:
- When is it supposed to be called? Before each call to
phy_ethtool_set_eee? Or once in the drivers init path?
- The name is a little bit misleading as it's mainly a
validity check. An actual "init" is done only if
parameter clk_stop_enable is set.
- It returns -EPROTONOSUPPORT if at least one link partner
doesn't advertise EEE for current speed/duplex. To me this
seems to be too restrictive. Example:
We're at 1Gbps/full and link partner advertises EEE for
100Mbps only. Then phy_init_eee returns -EPROTONOSUPPORT.
This keeps me from controlling 100Mbps EEE advertisement.
> Andrew
>
Heiner
next prev parent reply other threads:[~2019-08-15 13:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-15 9:45 [PATCH net-next 0/2] net: phy: realtek: map vendor-specific EEE registers to standard MMD registers Heiner Kallweit
2019-08-15 9:46 ` [PATCH net-next 1/2] net: phy: realtek: add support for EEE registers on integrated PHY's Heiner Kallweit
2019-08-15 9:47 ` [PATCH net-next 2/2] r8169: use the generic EEE management functions Heiner Kallweit
2019-08-15 12:35 ` Andrew Lunn
2019-08-15 13:02 ` Heiner Kallweit [this message]
2019-08-15 15:43 ` Florian Fainelli
2019-08-15 16:02 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bfd67eb3-0da7-b8a5-928a-a66802185b68@gmail.com \
--to=hkallweit1@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).