Re: [PATCH net-next v2 3/5] ice: migrate to netdev ops lock

[Alexander Lobakin <aleksander.lobakin@intel.com>]

From: Kohei Enju <kohei@enjuk.jp>
Date: Mon, 30 Mar 2026 03:01:04 +0900

> On 03/25 13:06, Tony Nguyen wrote:
>> From: Alexander Lobakin <aleksander.lobakin@intel.com>
>>
>> Queue management ops unconditionally enable netdev locking. The same
>> lock is taken by default by several NAPI configuration functions,
>> such as napi_enable() and netif_napi_set_irq().
>> Request ops locking in advance and make sure we use the _locked
>> counterparts of those functions to avoid deadlocks, taking the lock
>> manually where needed (suspend/resume, queue rebuild and resets).
To Simon:

Yes, the DCB code was reported earlier and I fixed it already in this
series. The DCB core takes RTNL, not netdev, so now ice calls the
functions which take the netdev lock.

But seems like the E-Switch code should take the lock, yeah.

To Kohei:

Ufff, I'm sorry I missed one more part, this RTNL -> netdev lock
transition is when you change one bit of the code and then the whole
cascade in some other part breaks...

I'll send a new rev once I fix and test both.

Thanks!
Olek