public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Heiner Kallweit <hkallweit1@gmail.com>
To: Florian Fainelli <f.fainelli@gmail.com>, Andrew Lunn <andrew@lunn.ch>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: phylib: Any PHY which reports link up during autoneg ?
Date: Thu, 16 Aug 2018 21:46:03 +0200	[thread overview]
Message-ID: <bffc8f21-66d4-83af-3d98-928121f3fffd@gmail.com> (raw)
In-Reply-To: <45f80146-f041-d6e6-a78b-b997456e03e1@gmail.com>

On 16.08.2018 21:21, Florian Fainelli wrote:
> On 08/16/2018 12:15 PM, Heiner Kallweit wrote:
>> When reading through the state machine code in phy.c I wondered whether
>> there is any PHY which reports the link as up during autonegotiation.
>> (It's about handling PHY_AN in the state machine, once we know the link
>> is up we still check whether aneg was completed. Is this needed?)
>>
>> At least the PHY's I have access to all report the link as down when
>> autonegotiating.
>> I checked also clause 22 of 802.3u, however found no clear definition
>> when a link should be considered up. There it's stated that it's
>> PHY-dependent.
>>
>> Can you shed any light on this?
> 
> I think the answer is no, there are no PHYs that can report a link UP
> during auto-negotiation that is, between the time you ask for an
> auto-negotiation to occur/restart, and the PHY reporting that it is
> done. By definition, auto-negotiation needs to figure out the common
> denominator between link partners, if, and only if that process
> completes (ANEG done), then the link should be UP.
> 
> If the link was reported UP during auto-negotiation, it would not be
> possible to be deterministic about:
> 
> - which link parameters changed between negotiation attempts
> - whether the link is DOWN due to a physical disconnection or a failure
> to agree on parameters
> 
Thanks for the clarification.
My confusion was mainly about the case of an autoneg restart if there's
an established connection. Because autoneg parameters are exchanged
by sideband signaling (link pulses), normal traffic may not be affected.
Except autoneg requires the rx/tx units to switch to some autoneg
processing mode.

Of course at one point in time, when both link partners have agreed
to a parameter set, they have to switch the mode, resulting in at
least a small window where link is down.

      reply	other threads:[~2018-08-16 22:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-16 19:15 phylib: Any PHY which reports link up during autoneg ? Heiner Kallweit
2018-08-16 19:21 ` Florian Fainelli
2018-08-16 19:46   ` Heiner Kallweit [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bffc8f21-66d4-83af-3d98-928121f3fffd@gmail.com \
    --to=hkallweit1@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=f.fainelli@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox