From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CFC6C43381 for ; Fri, 22 Feb 2019 17:16:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CFF6920675 for ; Fri, 22 Feb 2019 17:16:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="p23Fx+bZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726377AbfBVRQO (ORCPT ); Fri, 22 Feb 2019 12:16:14 -0500 Received: from mail-pl1-f195.google.com ([209.85.214.195]:38251 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725832AbfBVRQO (ORCPT ); Fri, 22 Feb 2019 12:16:14 -0500 Received: by mail-pl1-f195.google.com with SMTP id e5so1378344plb.5 for ; Fri, 22 Feb 2019 09:16:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:references:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=iSWXpCxaa8Ax+SnulbpJkJgIt+2dHdFN4BEd5G0ThNY=; b=p23Fx+bZWFwMGx6R0APmFuYMS2+kmi0OP9ljlrw96K+IUCPn54SOzKQTtWtLwZ1Xvc rcGxIdbY+LL6baqNOor725Y1/Z4O07e9iRXGk7voF7DF3K7b4QRzpB4hooEK3cv8xFNm 4pYoo+tuDAI1Sis8wkxOBjW3pL4xiNdehjr1xv8Ya3MRlxMfXhLN2a3VltTYqPAZpubp Ra546Sw3jzQ9D0B44tKdakmqvhR/jPDV84jUrWoRsgYx9OI4QX92mGieMSGGGz5c8wBS PZ+gxWgQS4CJ+qwmKlowp6+s9VZTHun1nXcBIX1BZcLiPipj7YT0FtV6IRqisEe5IVW0 RKtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=iSWXpCxaa8Ax+SnulbpJkJgIt+2dHdFN4BEd5G0ThNY=; b=T2t7Yjicrb/PAJFrcO5g+Hyhm8FUtaNpi2nlEVzLdjRlAPO0PKb4w8wV0kinfvQggT 9FgEZX+kpCOw2G6wuPGRml08uiNg5qFM0R5t7W2/7iokKEAjTYmrbxSK4brNBd+D1iMN i/W8kS7vM3b4aUprf41+MeebFUEIp8MIXBDi+FHB1XdcwfeWGHjgk2InPFZvMQ/ygBL5 RwdqulJCetNqKl2ZSpQHJzM7T0VzhWtwigUNSLTWz2yoXeK7FqsZrZB8GAjvs0z3usrG UhsE1WfEaF2guBaAFCI37/65sbSHLP15s2rQdPhpPhZeZcID6M7p8DJqxlLNgCaWQ/SA v4SQ== X-Gm-Message-State: AHQUAuY/Zy7Qi1pQGEJOStoULqhh0Rr0rq6g6Bl7xDSfKzSCytcsOyQR fHCmMeIIF3hiiXI9DLMbI6KcCd8m X-Google-Smtp-Source: AHgI3IaSR9vHaEiLAkgY7okIqX74qyE69evsaHg9Dc6J9HHMSFYxeNBLctcEbcrSYK6GDwQoNsDGjA== X-Received: by 2002:a17:902:8bc6:: with SMTP id r6mr5281044plo.235.1550855772981; Fri, 22 Feb 2019 09:16:12 -0800 (PST) Received: from [192.168.86.235] (c-73-241-150-70.hsd1.ca.comcast.net. [73.241.150.70]) by smtp.gmail.com with ESMTPSA id b12sm3246222pfb.30.2019.02.22.09.16.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Feb 2019 09:16:12 -0800 (PST) Subject: Re: [PATCH 1/3] ipv4: icmp: use icmp_sk_exit() From: Eric Dumazet To: Kefeng Wang , davem@davemloft.net, netdev@vger.kernel.org References: <20190222015800.192135-1-wangkefeng.wang@huawei.com> Message-ID: Date: Fri, 22 Feb 2019 09:16:10 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 02/22/2019 09:11 AM, Eric Dumazet wrote: > > > On 02/21/2019 05:57 PM, Kefeng Wang wrote: >> Simply use icmp_sk_exit() when inet_ctl_sock_create() fail in icmp_sk_init(). >> >> Signed-off-by: Kefeng Wang >> --- >> net/ipv4/icmp.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/net/ipv4/icmp.c b/net/ipv4/icmp.c >> index 065997f414e6..364cfe5e414b 100644 >> --- a/net/ipv4/icmp.c >> +++ b/net/ipv4/icmp.c >> @@ -1245,9 +1245,7 @@ static int __net_init icmp_sk_init(struct net *net) >> return 0; >> >> fail: >> - for_each_possible_cpu(i) >> - inet_ctl_sock_destroy(*per_cpu_ptr(net->ipv4.icmp_sk, i)); >> - free_percpu(net->ipv4.icmp_sk); >> + icmp_sk_exit(net); >> return err; >> } >> >> > > > I do not like this. Future changes in icmp_sk_exit() might trigger a bug in this seldom tested path. > Oh I see the next patches, now it makes sense. Please send a proper patch series, with a cover letter, so that it is obvious. Also you need to include "net-next" instead of plain [PATCH] to express this targets net-next tree. Carefully read Documentation/networking/netdev-FAQ.rst Thank you.