From: Sean Anderson <sean.anderson@linux.dev>
To: Simon Horman <horms@kernel.org>
Cc: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Andrew Lunn <andrew@lunn.ch>, Michal Simek <michal.simek@amd.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
linux-arm-kernel@lists.infradead.org,
Jakub Kicinski <kuba@kernel.org>,
Ariane Keller <ariane.keller@tik.ee.ethz.ch>
Subject: Re: [PATCH net-next 3/4] net: xilinx: axienet: Don't print if we go into promiscuous mode
Date: Thu, 15 Aug 2024 11:15:32 -0400 [thread overview]
Message-ID: <c0520caa-7c73-4a96-a21e-f0bbac95b5d3@linux.dev> (raw)
In-Reply-To: <20240815145948.GH632411@kernel.org>
On 8/15/24 10:59, Simon Horman wrote:
> On Mon, Aug 12, 2024 at 04:04:36PM -0400, Sean Anderson wrote:
>> A message about being in promiscuous mode is printed every time each
>> additional multicast address beyond four is added. Suppress this message
>> like is done in other drivers. And don't set IFF_PROMISC in ndev->flags;
>> contrary to the comment we don't have to inform the net subsystem.
>
> Hi Sean,
>
> FWIIW, this feels like two things that could be two patches.
>
> ...
OK
next prev parent reply other threads:[~2024-08-15 15:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-12 20:04 [PATCH net-next 0/4] net: xilinx: axienet: Multicast fixes and improvements Sean Anderson
2024-08-12 20:04 ` [PATCH net-next 1/4] net: xilinx: axienet: Always disable promiscuous mode Sean Anderson
2024-08-15 14:58 ` Simon Horman
2024-08-15 15:14 ` Sean Anderson
2024-08-15 15:17 ` Simon Horman
2024-08-12 20:04 ` [PATCH net-next 2/4] net: xilinx: axienet: Fix dangling multicast addresses Sean Anderson
2024-08-15 15:01 ` Simon Horman
2024-08-12 20:04 ` [PATCH net-next 3/4] net: xilinx: axienet: Don't print if we go into promiscuous mode Sean Anderson
2024-08-15 14:59 ` Simon Horman
2024-08-15 15:15 ` Sean Anderson [this message]
2024-08-12 20:04 ` [PATCH net-next 4/4] net: xilinx: axienet: Support IFF_ALLMULTI Sean Anderson
2024-08-15 15:02 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0520caa-7c73-4a96-a21e-f0bbac95b5d3@linux.dev \
--to=sean.anderson@linux.dev \
--cc=andrew@lunn.ch \
--cc=ariane.keller@tik.ee.ethz.ch \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=radhey.shyam.pandey@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).