From mboxrd@z Thu Jan 1 00:00:00 1970 From: Quentin Monnet Subject: Re: [oss-drivers] [PATCH net 0/2] cls_bpf: fix offload state tracking with block callbacks Date: Wed, 20 Dec 2017 11:33:55 +0000 Message-ID: References: <20171219213214.1084-1-jakub.kicinski@netronome.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: daniel@iogearbox.net, jiri@resnulli.us, oss-drivers@netronome.com To: Jakub Kicinski , netdev@vger.kernel.org Return-path: Received: from mail-lf0-f65.google.com ([209.85.215.65]:38480 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754722AbdLTLd6 (ORCPT ); Wed, 20 Dec 2017 06:33:58 -0500 Received: by mail-lf0-f65.google.com with SMTP id w196so5699923lff.5 for ; Wed, 20 Dec 2017 03:33:57 -0800 (PST) In-Reply-To: <20171219213214.1084-1-jakub.kicinski@netronome.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: 2017-12-19 13:32 UTC-0800 ~ Jakub Kicinski > Hi! > > After introduction of block callbacks classifiers can no longer track > offload state. cls_bpf used to do that in an attempt to move common > code from drivers to the core. Remove that functionality and fix > drivers. > > The user-visible bug this is fixing is that trying to offload a second > filter would trigger a spurious DESTROY and in turn disable the already > installed one. > > > Jakub Kicinski (2): > cls_bpf: fix offload assumptions after callback conversion > nfp: bpf: keep track of the offloaded program > > drivers/net/ethernet/netronome/nfp/bpf/main.c | 55 ++++++++++++---- > drivers/net/ethernet/netronome/nfp/bpf/main.h | 8 +++ > include/net/pkt_cls.h | 5 +- > net/sched/cls_bpf.c | 93 +++++++++++---------------- > 4 files changed, 92 insertions(+), 69 deletions(-) > Reviewed-by: Quentin Monnet