From: Florian Fainelli <f.fainelli@gmail.com>
To: David Miller <davem@davemloft.net>, herbert@gondor.apana.org.au
Cc: netdev@vger.kernel.org, fw@strlen.de, tgraf@suug.ch
Subject: Re: [PATCH net-next] rhashtable: Do not lower max_elems when max_size is zero
Date: Fri, 28 Apr 2017 08:42:12 -0700 [thread overview]
Message-ID: <c076bb39-a523-ffd1-2fa9-e942f654cc5e@gmail.com> (raw)
In-Reply-To: <20170428.101449.1468521013732143831.davem@davemloft.net>
On 04/28/2017 07:14 AM, David Miller wrote:
> From: Herbert Xu <herbert@gondor.apana.org.au>
> Date: Fri, 28 Apr 2017 14:10:48 +0800
>
>> The commit 6d684e54690c ("rhashtable: Cap total number of entries
>> to 2^31") breaks rhashtable users that do not set max_size. This
>> is because when max_size is zero max_elems is also incorrectly set
>> to zero instead of 2^31.
>>
>> This patch fixes it by only lowering max_elems when max_size is not
>> zero.
>>
>> Fixes: 6d684e54690c ("rhashtable: Cap total number of entries to 2^31")
>> Reported-by: Florian Fainelli <f.fainelli@gmail.com>
>> Reported-by: kernel test robot <fengguang.wu@intel.com>
>> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Tested-by: Florian Fainelli <f.fainelli@gmail.com>
Thanks Herbert
--
Florian
next prev parent reply other threads:[~2017-04-28 15:42 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-25 9:41 [PATCH net-next] rhashtable: remove insecure_max_entries param Florian Westphal
2017-04-25 11:04 ` Herbert Xu
2017-04-25 11:23 ` Florian Westphal
2017-04-25 13:28 ` Herbert Xu
2017-04-25 14:17 ` Florian Westphal
2017-04-25 14:48 ` David Miller
2017-04-27 5:44 ` rhashtable - Cap total number of entries to 2^31 Herbert Xu
2017-04-27 10:11 ` Florian Westphal
2017-04-27 10:13 ` Herbert Xu
2017-04-27 15:48 ` David Miller
2017-04-27 21:16 ` Florian Fainelli
2017-04-27 22:21 ` Florian Fainelli
2017-04-27 22:28 ` [PATCH net-next] rhashtable: Make sure max_size is non zero Florian Fainelli
2017-04-27 22:32 ` Florian Fainelli
2017-04-27 22:30 ` Florian Fainelli
2017-04-28 6:10 ` [PATCH net-next] rhashtable: Do not lower max_elems when max_size is zero Herbert Xu
2017-04-28 14:14 ` David Miller
2017-04-28 15:42 ` Florian Fainelli [this message]
2017-04-28 10:23 ` rhashtable - Cap total number of entries to 2^31 Christian Borntraeger
2017-04-28 11:31 ` Herbert Xu
2017-04-28 11:43 ` Christian Borntraeger
2017-04-28 2:10 ` [lkp-robot] [rhashtable ] df7008bdd5: Kernel_panic-not_syncing:rtnetlink_init:cannot_initialize_rtnetlink kernel test robot
2017-04-26 18:39 ` [PATCH net-next] rhashtable: remove insecure_max_entries param David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c076bb39-a523-ffd1-2fa9-e942f654cc5e@gmail.com \
--to=f.fainelli@gmail.com \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).