From: Eric Dumazet <eric.dumazet@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>,
Olga Albisser <olgabnd@gmail.com>,
netdev@vger.kernel.org
Cc: Olga Albisser <olga@albisser.org>,
Koen De Schepper <koen.de_schepper@nokia-bell-labs.com>,
Oliver Tilmans <olivier.tilmans@nokia-bell-labs.com>,
Bob Briscoe <research@bobbriscoe.net>,
Henrik Steen <henrist@henrist.net>
Subject: Re: [PATCH net-next] sched: add dualpi2 scheduler module
Date: Mon, 11 Mar 2019 09:12:25 -0700 [thread overview]
Message-ID: <c08b2b3d-5186-e16a-5e13-45c9c3f8e604@gmail.com> (raw)
In-Reply-To: <928e929e-9e13-5a08-07d4-ad3f4758833f@gmail.com>
On 03/11/2019 09:03 AM, Eric Dumazet wrote:
>
>
> On 03/11/2019 08:14 AM, Olga Albisser wrote:
>
>> +
>> +static u32 get_ecn_field(struct sk_buff *skb)
>> +{
>> + switch (skb->protocol) {
>
> tc_skb_protocol(skb)
>
>> + case cpu_to_be16(ETH_P_IP):
>
> Theoretically you have to use pskb_may_pull() before assuming network header is in the linear part of skb (skb->head)
You can take a look at dsmark_enqueue() for a starting point.
next prev parent reply other threads:[~2019-03-11 16:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-11 15:14 [PATCH net-next] sched: add dualpi2 scheduler module Olga Albisser
2019-03-11 15:41 ` Eric Dumazet
[not found] ` <CANFQ_ZhUOXwiWhmgzN227htWh5Wxg5PHBxHNp=T1Z8YTu-=O5w@mail.gmail.com>
2019-03-11 16:08 ` Eric Dumazet
2019-03-11 16:03 ` Eric Dumazet
2019-03-11 16:12 ` Eric Dumazet [this message]
2019-03-11 22:13 ` kbuild test robot
2019-03-14 16:48 ` Toke Høiland-Jørgensen
2019-03-14 17:18 ` Tilmans, Olivier (Nokia - BE/Antwerp)
2019-03-14 21:18 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c08b2b3d-5186-e16a-5e13-45c9c3f8e604@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=henrist@henrist.net \
--cc=koen.de_schepper@nokia-bell-labs.com \
--cc=netdev@vger.kernel.org \
--cc=olga@albisser.org \
--cc=olgabnd@gmail.com \
--cc=olivier.tilmans@nokia-bell-labs.com \
--cc=research@bobbriscoe.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).