From: Edward Cree <ecree.xilinx@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Cc: netdev <netdev@vger.kernel.org>,
Eric Dumazet <edumazet@google.com>,
John Sperbeck <jsperbeck@google.com>,
Jian Yang <jianyang@google.com>,
Maxim Mikityanskiy <maximmi@mellanox.com>,
Alexander Lobakin <alobakin@dlink.ru>,
Saeed Mahameed <saeedm@mellanox.com>,
Edward Cree <ecree@solarflare.com>
Subject: Re: [PATCH net] net: gro: do not keep too many GRO packets in napi->rx_list
Date: Fri, 5 Feb 2021 10:49:59 +0000 [thread overview]
Message-ID: <c09204f5-4e00-7375-2a22-e09c61b5db49@gmail.com> (raw)
In-Reply-To: <20210204213146.4192368-1-eric.dumazet@gmail.com>
On 04/02/2021 21:31, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@google.com>
>
> Commit c80794323e82 ("net: Fix packet reordering caused by GRO and
> listified RX cooperation") had the unfortunate effect of adding
> latencies in common workloads.
>
> Before the patch, GRO packets were immediately passed to
> upper stacks.
>
> After the patch, we can accumulate quite a lot of GRO
> packets (depdending on NAPI budget).
>
> My fix is counting in napi->rx_count number of segments
> instead of number of logical packets.
>
> Fixes: c80794323e82 ("net: Fix packet reordering caused by GRO and listified RX cooperation")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Bisected-by: John Sperbeck <jsperbeck@google.com>
> Tested-by: Jian Yang <jianyang@google.com>
> Cc: Maxim Mikityanskiy <maximmi@mellanox.com>
> Cc: Alexander Lobakin <alobakin@dlink.ru>
> Cc: Saeed Mahameed <saeedm@mellanox.com>
> Cc: Edward Cree <ecree@solarflare.com>
Reviewed-by: Edward Cree <ecree.xilinx@gmail.com>
next prev parent reply other threads:[~2021-02-05 23:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 21:31 [PATCH net] net: gro: do not keep too many GRO packets in napi->rx_list Eric Dumazet
2021-02-04 22:14 ` Saeed Mahameed
2021-02-04 22:44 ` Eric Dumazet
2021-02-05 13:03 ` Alexander Lobakin
2021-02-05 14:10 ` Eric Dumazet
2021-02-05 10:49 ` Edward Cree [this message]
2021-02-06 3:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c09204f5-4e00-7375-2a22-e09c61b5db49@gmail.com \
--to=ecree.xilinx@gmail.com \
--cc=alobakin@dlink.ru \
--cc=davem@davemloft.net \
--cc=ecree@solarflare.com \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=jianyang@google.com \
--cc=jsperbeck@google.com \
--cc=kuba@kernel.org \
--cc=maximmi@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).